nealef commented on PR #2026:
URL: https://github.com/apache/nuttx-apps/pull/2026#issuecomment-1880299715
The various `.def` files need to be updated for the
`SHMODULEFLAGS/SHCCFLAGS`. There doesn't seem to be a consistent place to put
them depending on the board type. This is what I am proposing to get things
working:
```
--- a/arch/risc-v/src/common/Toolchain.defs
+++ b/arch/risc-v/src/common/Toolchain.defs
@@ -104,8 +104,11 @@ ifneq ($(CONFIG_CXX_RTTI),y)
ARCHCXXFLAGS += -fno-rtti
endif
+SHMODULEFLAGS = -Bsymbolic -G -Bdynamic
+
ifeq ($(CONFIG_ARCH_RV32),y)
LDFLAGS += -melf32lriscv
+SHMODULEFLAGS += -melf32lriscv
else
LDFLAGS += -melf64lriscv
endif
diff --git a/boards/arm64/qemu/qemu-armv8a/scripts/Make.defs
b/boards/arm64/qemu/qemu-armv8a/scripts/Make.defs
index fce2c86eea..2b76e1b08d 100644
--- a/boards/arm64/qemu/qemu-armv8a/scripts/Make.defs
+++ b/boards/arm64/qemu/qemu-armv8a/scripts/Make.defs
@@ -46,6 +46,8 @@ CMODULEFLAGS = $(CFLAGS)
LDMODULEFLAGS = -r -e module_initialize
LDMODULEFLAGS += -T $(call
CONVERT_PATH,$(TOPDIR)/libs/libc/modlib/gnu-elf.ld)
+SHMODULEFLAGS = -Bsymbolic -G -Bdynamic
+
CELFFLAGS = $(CFLAGS) -mlong-calls # --target1-abs
CXXELFFLAGS = $(CXXFLAGS) -mlong-calls # --target1-abs
diff --git a/boards/sim/sim/sim/scripts/Make.defs
b/boards/sim/sim/sim/scripts/Make.defs
index 4a6670117d..9c2d84c269 100644
--- a/boards/sim/sim/sim/scripts/Make.defs
+++ b/boards/sim/sim/sim/scripts/Make.defs
@@ -268,7 +268,7 @@ else
endif
SHCCFLAGS = -fPIC -fPIE -fvisibility=default
-SHLDFLAGS = -shared -Bsymbolic -Bdynamic -G
+SHMODULEFLAGS = -shared -Bsymbolic -Bdynamic -G
ifeq ($(CONFIG_DEBUG_LINK_MAP),y)
ifeq ($(CONFIG_HOST_MACOS),)
@@ -280,6 +280,6 @@ ifeq ($(CONFIG_SIM_M32),y)
LDLINKFLAGS += -melf_i386
LDFLAGS += -m32
LDMODULEFLAGS += -melf_i386
- SHLDFLAGS += -melf_i386
+ SHMODULEFLAGS += -melf_i386
LDELFFLAGS += -melf_i386
endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
