xiaoxiang781216 commented on code in PR #11540: URL: https://github.com/apache/nuttx/pull/11540#discussion_r1451497317
########## fs/partition/fs_mbr.c: ########## @@ -36,7 +36,12 @@ ****************************************************************************/ #define MBR_SIZE 512 + +#if defined(CONFIG_FS_LARGEFILE) +#define MBR_LBA_TO_BLOCK(lba, blk) (((uint64_t) le32toh(lba) * 512 + (blk) - 1) / (blk)) Review Comment: we can simplify to: ```suggestion #define MBR_LBA_TO_BLOCK(lba, blk) (((blkcnt_t)le32toh(lba) * 512 + (blk) - 1) / (blk)) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
