tmedicci commented on PR #11554: URL: https://github.com/apache/nuttx/pull/11554#issuecomment-1893952022
> > Also, please note that the CI is failing to test [the `esp32s3-lcd-ev/ws2812` defconfig](https://github.com/apache/nuttx/actions/runs/7538371173/job/20527243651?pr=11554#step:7:874). This happens because the SPI is selected for the chip but the SPI driver on NuttX is not. You can make it a dependency in `nuttx/arch/xtensa/src/esp32s3/Kconfig`. Something like: > > ``` > > config ESP32S3_SPI > > bool > > select SPI_DRIVER > > default n > > ``` > > > > > > > > > > > > > > > > > > > > > > > > If you do that, probably the error will disappear. Please, don't forget to run `./tools/refresh.sh --silent chip:esp32s3` to make sure all defconfigs from ESP32-S3 are updated. Documentation for `refresh.sh` is [here](https://nuttx.apache.org/docs/latest/components/tools/index.html#refresh-sh) (but it doesn not show the `chip` "argument". If you are willing to help NuttX, maybe you could try to open a PR to update this doc too 😉 ) > > Well, if we add a `SPI_DRIVER` as the dependency of `ESP32S3_SPI`, more problems appear because `SPI_DRIVER` depends on more things like `SPI_EXCHANGE`. My idea is to add a macro `CONFIG_SPI_DRIVER` to determine whether we need to register spi bus. > > And build for `esp32s3-lcd-ev/ws2812` and `esp32s3-box/lvgl-3` with `-Werror`. This method can pass the build. Forget about it: it is better to just change the config used to build `esp32s3_board_spidev.c` just like it is done on ESP32: https://github.com/apache/incubator-nuttx/blob/e11627d0fba481086ccc1e640eeadd39bfa38ccf/boards/xtensa/esp32/common/src/Make.defs#L63 In `boards/xtensa/esp32s3/common/src/Make.defs`, just change `CONFIG_ESP32S3_SPI` to `CONFIG_SPI_DRIVER` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
