tmedicci commented on code in PR #11563: URL: https://github.com/apache/nuttx/pull/11563#discussion_r1459608055
########## arch/xtensa/src/esp32/Make.defs: ########## @@ -111,8 +111,8 @@ CHIP_CSRCS += esp32_himem.c CHIP_CSRCS += esp32_himem_chardev.c endif -ifeq ($(CONFIG_ESP32_EFUSE),y) CHIP_CSRCS += esp32_efuse.c Review Comment: Because the chip revision is read from efuses, but we don't need to implement all efuses features, so I modified `esp32_efuse.c` and added the `CONFIG_ESP32_EFUSE` to build the required sources when all efuse features are required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org