jlaitine commented on a change in pull request #1115:
URL: https://github.com/apache/incubator-nuttx/pull/1115#discussion_r431120985



##########
File path: arch/arm/src/samv7/sam_spi_slave.c
##########
@@ -485,7 +486,8 @@ static int spi_interrupt(int irq, void *context, FAR void 
*arg)
 
           /* Report the receipt of data to the SPI device driver */
 
-          SPI_SDEV_RECEIVE(priv->sdev, data);
+          SPI_SDEV_RECEIVE(priv->sdev, (const uint16_t *)&data,

Review comment:
       maybe, since this driver can't buffer the data. But in practice, this 
implements the same functionality as before, so any slave device currently 
using this wouldn't assume that the controller driver would buffer data anyhow. 
I'll leave it to you to decide. I can add an error in here, but I'd rather not 
modify this file too much since I can't test it.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to