casaroli opened a new pull request, #11690:
URL: https://github.com/apache/nuttx/pull/11690

   ## Summary
   
   This is a tentative alternative to https://github.com/apache/nuttx/pull/11202
   
   This is a PoC of one of the potentically possible ways to let the 
applications customize build-time options of NuttX (in `Make.defs`). For 
example, the `libtest` example is adding some libs to `EXTRA_LIBS`, and this is 
not being set.
   
   I tried different approaches to do this and it looks like this is the less 
invasive of doing it in the current build system that I could come up with.
   
   Maybe this is not good enough to merge, we might still polish it to make it 
cleaner, however I just wanted to share the idea and get feedback from the 
devs. Please be nice! :)
   
   If I come up with other solutions, I will open other draft PRs to get 
feedback.
   
   ## Impact
   
   - Fixes https://github.com/apache/nuttx-apps/issues/2189
   - Example apps can now tweak nuttx build-time variables
   
   ## Testing
   
   Enable `libtest` example and the executable (`EXAMPLES_LIBTEST` and 
`EXAMPLES_LIBTEST_CMDTOOL`) and it works out of the box. I have tested for 
`esp32s3-devkit:nsh` and `sim:nsh`
   
   We could also enable the `libtest` example by default in a config, so the CI 
will make sure this will keep working.
   ## Summary
   
   This will allow apps to tweak build configuration of NuttX
   
   Since apps/Make.defs include nuttx/Make.defs, we check if it the apps dir is 
available and include it, otherwise we just include nuttx/Make.defs and keep 
the old behavior.
   
   This allows EXTRA_LIBS and some other system-wide tweaks be applied in any 
apps and make it work with the nuttx Makefiles.
   
   ## Impact
   
   ## Testing
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to