xiaoxiang781216 commented on code in PR #11721: URL: https://github.com/apache/nuttx/pull/11721#discussion_r1494433823
########## boards/risc-v/esp32h2/esp32h2-devkit/src/esp32h2-devkit.h: ########## @@ -31,6 +31,19 @@ * Pre-processor Definitions ****************************************************************************/ +/* RMT gpio */ + +#define RMT_RXCHANNEL 2 +#define RMT_TXCHANNEL 0 + +#ifdef CONFIG_RMT_LOOP_TEST_MODE +# define RMT_INPUT_PIN 0 Review Comment: remove two space to algin with line 37 ########## boards/risc-v/esp32c3/esp32c3-generic/src/esp32c3-generic.h: ########## @@ -31,6 +31,19 @@ * Pre-processor Definitions ****************************************************************************/ +/* RMT gpio */ + +#define RMT_RXCHANNEL 2 +#define RMT_TXCHANNEL 0 + +#ifdef CONFIG_RMT_LOOP_TEST_MODE +# define RMT_INPUT_PIN 0 Review Comment: ditto ########## boards/risc-v/esp32c6/esp32c6-devkit/src/esp32c6-devkit.h: ########## @@ -31,6 +31,19 @@ * Pre-processor Definitions ****************************************************************************/ +/* RMT gpio */ + +#define RMT_RXCHANNEL 2 +#define RMT_TXCHANNEL 0 + +#ifdef CONFIG_RMT_LOOP_TEST_MODE +# define RMT_INPUT_PIN 0 Review Comment: remove two space to align with line 37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
