xiaoxiang781216 commented on code in PR #2300: URL: https://github.com/apache/nuttx-apps/pull/2300#discussion_r1501472111
########## nshlib/nsh_prompt.c: ########## @@ -0,0 +1,108 @@ +/**************************************************************************** + * apps/nshlib/nsh_prompt.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <string.h> + +#ifndef CONFIG_NSH_CLE +# include "system/readline.h" +#endif + +#include "nsh.h" + +/**************************************************************************** + * Preprocessor Macros + ****************************************************************************/ + +#define PROMPT_SIZE CONFIG_NSH_PROMPT_MAX +#define SUFFIX_SIZE CONFIG_NSH_PROMPT_SUFFIX_MAX + +#define SUF_POS_MAX (PROMPT_SIZE - SUFFIX_SIZE) Review Comment: ```suggestion #define NSH_SUFFIX_MAX (CONFIG_NSH_PROMPT_MAX - sizeof(CONFIG_NSH_PROMPT_SUFFIX)) ``` and remove NSH_PROMPT_SUFFIX_MAX from Kconfig -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
