xiaoxiang781216 commented on code in PR #11777:
URL: https://github.com/apache/nuttx/pull/11777#discussion_r1506391344
##########
include/nuttx/sched.h:
##########
@@ -412,6 +419,52 @@ struct binary_s; /* Forward reference
/* Defined in
include/nuttx/binfmt/binfmt.h */
#endif
+/* This structure encapsulates all variables associated with getopt(). */
+
+struct getopt_s
Review Comment:
could we keep getopt_s and task_info_s in tls.h?
##########
include/nuttx/sched.h:
##########
@@ -480,6 +533,9 @@ struct task_group_s
/* Thread local storage ***************************************************/
+#ifndef CONFIG_MM_KERNEL_HEAP
+ struct task_info_s tg_info_;
Review Comment:
CONFIG_TLS_ALIGNED should be prefer than CONFIG_MM_KERNEL_HEAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
