xiaoxiang781216 commented on a change in pull request #1149:
URL: https://github.com/apache/incubator-nuttx/pull/1149#discussion_r432809102



##########
File path: tools/Makefile.unix
##########
@@ -381,9 +370,9 @@ include tools/LibTargets.mk
 # is an archive.  Exactly what is performed during pass1 or what it generates
 # is unknown to this makefile unless CONFIG_PASS1_OBJECT is defined.
 
-pass1: $(USERLIBS)
+pass1: tools/incdir$(HOSTEXEEXT) $(USERLIBS)

Review comment:
       This change will break the concurrent build since tools/incdir and 
libraries in $(USERLIBS) and $(NUTTxLIBS) don't have the dependency and will 
build at the same time.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to