xiaoxiang781216 commented on code in PR #11848: URL: https://github.com/apache/nuttx/pull/11848#discussion_r1514673720
########## sched/group/group.h: ########## @@ -58,9 +58,12 @@ void task_initialize(void); int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype); void group_initialize(FAR struct task_tcb_s *tcb); -#ifndef CONFIG_DISABLE_PTHREAD +#ifdef HAVE_GROUP_MEMBERS int group_bind(FAR struct pthread_tcb_s *tcb); int group_join(FAR struct pthread_tcb_s *tcb); +#else +# define group_bind(tcb) OK Review Comment: why need add empty macro? ########## sched/group/group.h: ########## @@ -58,9 +58,12 @@ void task_initialize(void); int group_allocate(FAR struct task_tcb_s *tcb, uint8_t ttype); void group_initialize(FAR struct task_tcb_s *tcb); -#ifndef CONFIG_DISABLE_PTHREAD +#ifdef HAVE_GROUP_MEMBERS Review Comment: why need change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
