tmedicci commented on code in PR #12055:
URL: https://github.com/apache/nuttx/pull/12055#discussion_r1553683202
##########
arch/xtensa/src/esp32s3/esp32s3_gpio.c:
##########
@@ -207,6 +208,17 @@ int esp32s3_configgpio(uint32_t pin, gpio_pinattr_t attr)
func = 0;
cntrl = 0;
+ /* if pin 19 or 20 disable the USB/JTAG function and pull-up */
+
+ if (pin == 19 || pin == 20)
+ {
+ uint32_t regval;
+ regval = getreg32(USB_SERIAL_JTAG_CONF0_REG);
+ regval &= ~(USB_SERIAL_JTAG_USB_PAD_ENABLE |
+ USB_SERIAL_JTAG_DP_PULLUP);
Review Comment:
```suggestion
regval &= ~(USB_SERIAL_JTAG_USB_PAD_ENABLE |
USB_SERIAL_JTAG_DP_PULLUP);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
