xiaoxiang781216 commented on code in PR #12076:
URL: https://github.com/apache/nuttx/pull/12076#discussion_r1554655469
##########
arch/xtensa/src/esp32s3/Kconfig:
##########
@@ -366,26 +366,26 @@ config ESP32S3_I2S0_SAMPLE_RATE
config ESP32S3_I2S0_BCLKPIN
int "I2S0 BCLK pin"
default 4
- range 0 33 if ESP32S3_I2S0_ROLE_MASTER
- range 0 39 if ESP32S3_I2S0_ROLE_SLAVE
+ range 0 48 if ESP32S3_I2S0_ROLE_MASTER
+ range 0 48 if ESP32S3_I2S0_ROLE_SLAVE
Review Comment:
both ESP32S3_I2S0_ROLE_MASTER and ESP32S3_I2S0_ROLE_SLAVE have the same
range in your patch, why not just change to `range 0 48` without if condition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
