This is an automated email from the ASF dual-hosted git repository.

jerpelea pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git

commit 932c41debbf18fa8210e6c33891aa6aab61605a8
Author: Zhe Weng <weng...@xiaomi.com>
AuthorDate: Fri Apr 12 10:21:44 2024 +0800

    net/nat: Remove unnecessary logic in inbound logic
    
    Finish https://github.com/apache/nuttx/pull/12116#discussion_r1560880897
    
    Signed-off-by: Zhe Weng <weng...@xiaomi.com>
---
 net/nat/ipv4_nat.c | 9 +--------
 net/nat/ipv6_nat.c | 9 +--------
 2 files changed, 2 insertions(+), 16 deletions(-)

diff --git a/net/nat/ipv4_nat.c b/net/nat/ipv4_nat.c
index d5a3edb3a4..60098a5a00 100644
--- a/net/nat/ipv4_nat.c
+++ b/net/nat/ipv4_nat.c
@@ -744,14 +744,7 @@ void ipv4_nat_inbound(FAR struct net_driver_s *dev,
   if (IFF_IS_NAT(dev->d_flags) &&
       net_ipv4addr_hdrcmp(ipv4->destipaddr, &dev->d_ipaddr))
     {
-      FAR ipv4_nat_entry_t *entry =
-          ipv4_nat_inbound_internal(ipv4, NAT_MANIP_DST);
-      if (!entry)
-        {
-          /* Inbound without entry is OK (e.g. towards NuttX itself), skip. */
-
-          return;
-        }
+      ipv4_nat_inbound_internal(ipv4, NAT_MANIP_DST);
     }
 }
 
diff --git a/net/nat/ipv6_nat.c b/net/nat/ipv6_nat.c
index 6331ffed89..a77132040c 100644
--- a/net/nat/ipv6_nat.c
+++ b/net/nat/ipv6_nat.c
@@ -634,14 +634,7 @@ void ipv6_nat_inbound(FAR struct net_driver_s *dev,
   if (IFF_IS_NAT(dev->d_flags) &&
       NETDEV_IS_MY_V6ADDR(dev, ipv6->destipaddr))
     {
-      FAR ipv6_nat_entry_t *entry =
-          ipv6_nat_inbound_internal(ipv6, NAT_MANIP_DST);
-      if (!entry)
-        {
-          /* Inbound without entry is OK (e.g. towards NuttX itself), skip. */
-
-          return;
-        }
+      ipv6_nat_inbound_internal(ipv6, NAT_MANIP_DST);
     }
 }
 

Reply via email to