acassis commented on PR #12095:
URL: https://github.com/apache/nuttx/pull/12095#issuecomment-2054203027
> @xiaoxiang781216 @btashton @pkarashchenko Seems like there is a fail in
our nxstyle coding check, it is allowing single line if () without { }, as
requested: https://nuttx.apache.org/docs/latest/contributing/coding_style.html
>
> Single line if () without { } is ticking bomb waiting for some victim!
Strange there is a rule for it in the tools/uncrustify.cfg that Greg and Bob
Feretich was trying to do in 2018:
```
mod_full_brace_if = add # "if (a) { a--; }" vs "if (a) a--;"
```
But there isn't a check for it on nxstyle, I noticed we have many files with
this issue, I will open an issue and submit a patch later. See:
```
$ git grep "if (" | grep "\;"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
