wengzhe commented on code in PR #12156:
URL: https://github.com/apache/nuttx/pull/12156#discussion_r1567359984


##########
net/nat/ipv4_nat_entry.c:
##########
@@ -195,39 +204,47 @@ static void ipv4_nat_entry_delete(FAR ipv4_nat_entry_t 
*entry)
  ****************************************************************************/
 
 #if CONFIG_NET_NAT_ENTRY_RECLAIM_SEC > 0
+static void ipv4_nat_reclaim_entry_cb(FAR ipv4_nat_entry_t *entry,
+                                      FAR void *arg)
+{
+  int32_t current_time = *(int32_t *)arg;

Review Comment:
   I mean, the expiration is in "seconds", we won't reach 2^31 seconds to 
expire an entry. (And 32768/65536 seconds is not enough while 2^63 is too much)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to