acassis commented on code in PR #12170:
URL: https://github.com/apache/nuttx/pull/12170#discussion_r1568918380


##########
arch/arm64/src/imx9/imx9_gpioirq.c:
##########
@@ -236,8 +236,8 @@ int imx9_gpioirq_enable(gpio_pinset_t pinset)
 {
   uint32_t  port = (pinset & GPIO_PORT_MASK) >> GPIO_PORT_SHIFT;
   uint32_t  pin  = (pinset & GPIO_PIN_MASK) >> GPIO_PIN_SHIFT;
-  uint32_t  icr  = (pinset & GPIO_INTCFG_MASK) >> GPIO_INTCFG_SHIFT;
   uint32_t  both = (pinset & GPIO_INTBOTHCFG_MASK) >> GPIO_INTBOTHCFG_SHIFT;
+  uint32_t  icr  = (pinset & GPIO_INTCFG_MASK);

Review Comment:
   Why was GPIO_INTCFG_SHIFT dropped?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to