pkarashchenko commented on code in PR #2366:
URL: https://github.com/apache/nuttx-apps/pull/2366#discussion_r1576405275
##########
boot/mcuboot/Makefile:
##########
@@ -75,8 +76,8 @@ CXXFLAGS += ${INCDIR_PREFIX}mcuboot/ext/tinycrypt/lib/include
endif
$(MCUBOOT_TARBALL):
- $(Q) echo "Downloading MCUboot-$(MCUBOOT_VERSION)"
- $(Q) curl -O -L
https://github.com/mcu-tools/mcuboot/archive/$(MCUBOOT_TARBALL)
+ $(Q) echo "Downloading MCUboot-$(MCUBOOT_VERSION) from
$(MCUBOOT_REPOSITORY)"
+ $(Q) curl -O -L $(MCUBOOT_REPOSITORY)/archive/$(MCUBOOT_TARBALL)
Review Comment:
So you rely that by default `curl` will select https?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
