jlaitine commented on a change in pull request #1165:
URL: https://github.com/apache/incubator-nuttx/pull/1165#discussion_r434016051
##########
File path: arch/arm/src/stm32h7/stm32_spi.c
##########
@@ -2114,6 +2109,11 @@ static void spi_exchange(FAR struct spi_dev_s *dev, FAR
const void *txbuffer,
* bits in the SPI_CFG1 register, if DMA Tx and/or DMA Rx are used.
*/
+ /* TX transmission must be completed before shuttind down the SPI */
Review comment:
I am not quite sure why you see this as an one atomic change; maybe I
have accidentally mangled the commits together while cherry picking and
resolving conflicts accross my messy branches.
Anyhow, I am ok to squash them as you wish, I'll do it as soon as I open my
computer next time, at latest tomorrow morning. Please wait with merging until
I get there :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
