masayuki2009 commented on code in PR #12282:
URL: https://github.com/apache/nuttx/pull/12282#discussion_r1590884850
##########
sched/Kconfig:
##########
@@ -351,7 +351,6 @@ config SMP
depends on ARCH_HAVE_TESTSET
depends on ARCH_INTERRUPTSTACK != 0
select SPINLOCK
- select SCHED_RESUMESCHEDULER
select IRQCOUNT
Review Comment:
@hujun260
We need clearer explanation in the commit log why you remove this line.
##########
arch/sparc/src/s698pm/s698pm_cpustart.c:
##########
@@ -84,12 +82,12 @@ void s698pm_cpu_boot(void)
#ifdef CONFIG_SCHED_INSTRUMENTATION
/* Notify that this CPU has started */
- sched_note_cpu_started(tcb);
+ sched_note_cpu_started(this_task());
#endif
/* Reset scheduler parameters */
- nxsched_resume_scheduler(tcb);
+ nxsched_resume_scheduler(this_task());
Review Comment:
@hujun260
Does this change relates to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
