patacongo commented on a change in pull request #1175:
URL: https://github.com/apache/incubator-nuttx/pull/1175#discussion_r434600085
##########
File path: boards/arm/tms570/launchxl-tms57004/scripts/flash-sram.ld
##########
@@ -43,8 +43,6 @@ MEMORY
sram (rwx) : ORIGIN = 0x08000000, LENGTH = 32K
}
-OUTPUT_ARCH(arm)
-OUTPUT_FORMAT(elf32-bigarm)
Review comment:
I tried to build a TMS570 configuration, but it needs an
armeb-nuttx-eabi-gcc (or armeb-none-eabi-gcc) toolchain and don't have one
right now.
Since it requires a special toolchain, I suppose that it most likely will
generate the correct architecture. It would be nice to verify that however.
We really need to stop making so many changes that are not tested. We break
too much stuff doing that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]