yamt commented on code in PR #12310:
URL: https://github.com/apache/nuttx/pull/12310#discussion_r1595372410
##########
boards/xtensa/esp32s3/esp32s3-devkit/Kconfig:
##########
@@ -26,6 +26,10 @@ config ESP32S3_STORAGE_MTD_OFFSET
config ESP32S3_STORAGE_MTD_SIZE
hex "Storage MTD size in SPI Flash"
+ range 0x0 400000 if ESP32S3_FLASH_4M
Review Comment:
do you mean 0x400000?
##########
boards/xtensa/esp32s3/esp32s3-meadow/Kconfig:
##########
@@ -15,6 +15,10 @@ config ESP32S3_STORAGE_MTD_OFFSET
config ESP32S3_STORAGE_MTD_SIZE
hex "Storage MTD size in SPI Flash"
default 0x100000
Review Comment:
is it intentional to use a different order of default and range? why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
