pkarashchenko commented on code in PR #12382:
URL: https://github.com/apache/nuttx/pull/12382#discussion_r1609642076
##########
arch/arm/src/samv7/sam_serial_spi.c:
##########
@@ -69,16 +69,16 @@
struct sam_serial_spi_pins_s
{
- uint32_t mosi;
- uint32_t miso;
- uint32_t sck;
- uint32_t nss;
+ const uint32_t mosi;
+ const uint32_t miso;
+ const uint32_t sck;
+ const uint32_t nss;
};
struct sam_serial_spi_s
{
struct sam_serial_spi_pins_s pins;
- uint32_t base; /* SPI controller register base address */
+ const uint32_t base; /* SPI controller register base address */
Review Comment:
I can revert. It was just from logical perspective as the values of the base
address should not change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
