michallenc commented on PR #12392: URL: https://github.com/apache/nuttx/pull/12392#issuecomment-2126905284
> @michallenc could you please take a look here. I'm back porting changes from some of my older branches and want to make sure that I didn't make any mistake. I detected this issue when was working on SocketLIN support. The `CONFIG_USART0_ISSPI`/`CONFIG_USART1_ISSPI`/`CONFIG_USART2_ISSPI` are not defined anywhere and selecting of USART SPI or 1-wire drivers for USARTs will lead to undef of `CONFIG_SAMV7_USART0`/`CONFIG_SAMV7_USART1`/`CONFIG_SAMV7_USART2`, so clocks will not be enabled. USART SPI and 1-wire contain code to mix pins, but clock configuration is missing for 1-wire while present for USART SPI. I hope I did all correctly I don't have a board with me today so I will check tomorrow, but it seems good. It is interesting, I clearly missed clock enable when implementing 1-wire interface, but I tested the peripheral and it was working. But it certainly should be there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
