xuxin930 commented on code in PR #12423:
URL: https://github.com/apache/nuttx/pull/12423#discussion_r1619716423
##########
CMakeLists.txt:
##########
@@ -622,9 +622,8 @@ if(NOT CONFIG_ARCH_SIM)
# TODO: nostart/nodefault not applicable to nuttx toolchain
target_link_libraries(
- nuttx
- PRIVATE ${NUTTX_EXTRA_FLAGS} -Wl,--script=${ldscript} -Wl,--start-group
- ${nuttx_libs} ${nuttx_extra_libs} -Wl,--end-group)
+ nuttx PRIVATE -Wl,--script=${ldscript} -Wl,--start-group ${nuttx_libs}
Review Comment:
> Why ${NUTTX_EXTRA_FLAGS} was removed?
This NUTTX_EXTRA_FLAGS is a compile option set in the configure stage. I
think this is redundant when linking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
