anchao commented on code in PR #12431:
URL: https://github.com/apache/nuttx/pull/12431#discussion_r1621726708


##########
net/netdev/netdev_iob.c:
##########
@@ -84,6 +84,43 @@ int netdev_iob_prepare(FAR struct net_driver_s *dev, bool 
throttled,
   return OK;
 }
 
+/****************************************************************************
+ * Name: netdev_iob_prepare_dynamic
+ *
+ * Description:
+ *   Pre-alloc the iob for the data to be sent.
+ *
+ * Assumptions:
+ *   The caller has locked the network.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_IOB_ALLOC
+void netdev_iob_prepare_dynamic(FAR struct net_driver_s *dev, uint16_t size)
+{
+  FAR struct iob_s *iob = NULL;

Review Comment:
   ```suggestion
     FAR struct iob_s *iob;
   ```



##########
net/Kconfig:
##########
@@ -146,6 +146,13 @@ config NET_LL_GUARDSIZE
                the L2/L3 (MAC/IP) data on Network layer, which will be 
beneficial
                to L3 network layer protocol transparent transmission and 
forwarding
 
+config NET_JUMBO_FRAME

Review Comment:
   do we have the jumbo frame user case on real hardware device?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to