yf13 commented on code in PR #12427:
URL: https://github.com/apache/nuttx/pull/12427#discussion_r1623295047
##########
sched/Kconfig:
##########
@@ -1937,3 +1937,14 @@ config GROUP_KILL_CHILDREN_TIMEOUT_MS
> 0 means wait timeout
= 0 means don't do kill signal
+config INITIAL_PID_LIMIT
Review Comment:
@pkarashchenko , I feel like shor and direct names as they are simpler for
users. Actually the length doesn't have to be power-of-two, it is just a
requirement from current hashing design. Direct names also last longer -- so
even if later we drop the power-of-two requirements, names like
`INITIAL_PID_LIMIT` still work.
But for `#warning` vs `static_assertion`. I need a clear direction from you
and @xiaoxiang781216.
##########
sched/Kconfig:
##########
@@ -1937,3 +1937,14 @@ config GROUP_KILL_CHILDREN_TIMEOUT_MS
> 0 means wait timeout
= 0 means don't do kill signal
+config INITIAL_PID_LIMIT
Review Comment:
@pkarashchenko , I feel like shor and direct names as they are simpler for
users. Actually the length doesn't have to be power-of-two, it is just a
requirement from current hashing design. Direct names also last longer -- so
even if later we drop the power-of-two requirements, names like
`INITIAL_PID_LIMIT` still work.
But for `#warning` vs `static_assert`. I need a clear direction from you
and @xiaoxiang781216.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
