yf13 commented on code in PR #12427:
URL: https://github.com/apache/nuttx/pull/12427#discussion_r1623295047
##########
sched/Kconfig:
##########
@@ -1937,3 +1937,14 @@ config GROUP_KILL_CHILDREN_TIMEOUT_MS
> 0 means wait timeout
= 0 means don't do kill signal
+config INITIAL_PID_LIMIT
Review Comment:
@pkarashchenko, thanks a lot! Names really worth more thinking. I still feel
like short and direct names as they are simpler and stabler. Actually here the
length doesn't have to be power-of-two, it is a requirement from current
implementation. Even if the requirement later disappears with a different
implementation, direct names like `INITIAL_PID_LIMIT` still hold. Does this
make sense?
But for `#error` vs `static_assert`. I need clear direction from you and
@xiaoxiang781216. My grep of local tree shows that use of `#error` is 3500+
while `static_assert` is 50-.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
