xiaoxiang781216 commented on code in PR #12432: URL: https://github.com/apache/nuttx/pull/12432#discussion_r1624526224
########## boards/arm/lpc17xx_40xx/lpc4088-devkit/scripts/memory.ld: ########## @@ -73,9 +73,9 @@ MEMORY /* 64Kb of SRAM in the CPU block */ - ksram (rwx) : ORIGIN = 0x10000000, LENGTH = 4K /* May include waste */ - usram (rwx) : ORIGIN = 0x10001000, LENGTH = 4K - xsram (rwx) : ORIGIN = 0x10002000, LENGTH = 24K /* All used as heap */ + ksram (rwx) : ORIGIN = 0x10000000, LENGTH = 6K /* May include waste */ Review Comment: why need ########## sched/mqueue/mq_initialize.c: ########## @@ -52,6 +52,22 @@ struct list_node g_msgfreeirq; #endif +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* This is a pool of pre-allocated message queue buffers */ + +static uint8_t g_msgpool[ Review Comment: the alignment mayn't match the requirementt of mqueue_msg_s/msgbuf_s ########## sched/signal/sig_initialize.c: ########## @@ -68,6 +68,17 @@ sq_queue_t g_sigpendingsignal; sq_queue_t g_sigpendingirqsignal; +/**************************************************************************** + * Private Data + ****************************************************************************/ + +/* This is a pool of pre-allocated signal structures buffers */ + +static uint8_t g_sigpool[ Review Comment: dittto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
