anchao commented on code in PR #12624:
URL: https://github.com/apache/nuttx/pull/12624#discussion_r1666131398
##########
arch/sim/src/Makefile:
##########
@@ -414,6 +414,9 @@ ifeq ($(CONFIG_MM_KASAN_GLOBAL),y)
.kasan.global : {KEEP(*(.data..LASAN0)) KEEP
(*(.data.rel.local..LASAN0)) }\n \
.interp : {*(.interp)}/g' nuttx.ld
endif
+ifneq ($(CONFIG_SIM_CUSTOM_DATA_SECTION),"")
+ $(Q) sed -i '/\.data *:/i $(shell echo
$(CONFIG_SIM_CUSTOM_DATA_SECTION))' nuttx.ld
Review Comment:
This config contains double quotes `"`, but the sed /i syntax does not
support eliminating them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
