sumpfralle commented on PR #12630: URL: https://github.com/apache/nuttx/pull/12630#issuecomment-2211067968
Thank you for taking a look! > I think you forgot to include the header files, this is causing the failures in the CI I think, everything is there. The CI (a static checker?) complains, since the macro is sadly defined in the header file *below* the one function using it. This function (in this header file) is a `static inline` function. Thus, during compilation the macro is already known whenever this inline function is used. At least I did not see a complaint in my compiler run. But I can obviously move the previously existing macro definition (`spin_is_locked`) a bit higher in order to satisfy the static checker (and to avoid confusion for future readers). I just wanted to keep the diff minimal. But the real problem is the pointer/value issue, which I described above, I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
