xiaoxiang781216 commented on PR #2437: URL: https://github.com/apache/nuttx-apps/pull/2437#issuecomment-2214472410
> > should we keep rust_hello independent from the hardware? but create a new example(e.g. blink_rust)? > > @xiaoxiang781216 Good point! Rushabh suggested a separate app, but I thought we should extend hello_rust because: (1) By convention, there seems to be only 1 sample app per language? hello_nim, hello_zig, hello_d, ... (2) If we look at [hello_nim](https://github.com/apache/nuttx-apps/blob/master/examples/hello_nim/hello_nim_async.nim): It's actually doing quite a lot. Maybe hello_rust should also do something substantial? (3) Our Rust Blinky App will terminate gracefully if the LED Driver is missing anyway > > If we have no concerns about breaking convention (1), then sure we can split into a blink_rust app. Lemme know what you think. Thanks! It' fine to put into hello_rust If the demo doesn't depend on any hardware feature and can run with a basic porting. But, the change in this patch depends on userleds which mayn't exist on many board. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
