LuchianMihai opened a new issue, #12653: URL: https://github.com/apache/nuttx/issues/12653
Recently I've started to learn the internals of NuttX. I'm currently using [nucleo f429zi](https://www.st.com/en/evaluation-tools/nucleo-f429zi.html) board. While looking at lower half stm32 serial driver I've noticed a few this that does not make sense, like: * interrupt enable mask (ie) struct member as uint16_t shared for two 32 bit registers. * up_txint guarded by SERIAL_HAVE_RXDMA_OPS define & up_rxint guarded by SERIAL_HAVE_TXDMA_OPS define, which I find odd, shouldn't it be reversed? * up_dma_setup enables interrupts, while up_dma_rxint (which from docs should enable interrupts) does nothing. This may be due to limitation of my first point. * up_*usartint functions are bit ackward to use, as stated above, I interact with two register using only one 16 bit variable. I would like to try my hand at some refactorization, but I know nothing about the current status of this driver. Would some changes be welcomed? If yes, which ones? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
