linguini1 commented on code in PR #12715: URL: https://github.com/apache/nuttx/pull/12715#discussion_r1684370463
########## boards/arm/rp2040/common/src/rp2040_common_bringup.c: ########## @@ -68,6 +68,11 @@ #include "rp2040_bmp280.h" #endif +#ifdef CONFIG_SENSORS_SHT4X +#include <nuttx/sensors/sht4x.h> +#include "rp2040_i2c.h" Review Comment: @acassis I do use that function call, which is why I included the I2C header you mentioned in your last comment. The reason I left that function call in the rp2040 bring up is because it seems like the architecture specific logic should stay out of the driver, since I want it to work on all architectures with I2C. I have seen this done for the SHT3x and SHT21. It made more sense to me to keep it in the architecture bring-up logic. I was hoping to find some way to access the I2C driver structure without an architecture specific initialization function, but since I haven't been able to, I think this way ensures that the driver can run on all architectures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
