raiden00pl commented on code in PR #12765: URL: https://github.com/apache/nuttx/pull/12765#discussion_r1693957794
########## drivers/drivers_initialize.c: ########## @@ -49,6 +49,15 @@ #include <nuttx/virtio/virtio.h> #include <nuttx/drivers/optee.h> +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#if (defined(CONFIG_LWL_CONSOLE) + defined(CONFIG_CONSOLE_SYSLOG) + \ + defined(CONFIG_SERIAL_RTT_CONSOLE) + defined(CONFIG_RPMSG_UART_CONSOLE)) > 1 +# error More than one console driver selected. Check your configuration ! Review Comment: > how about move ALL CONFIG_XXX_CONSOLE under a choice? That would be ideal, but at the moment it's not possible. Some console drivers depends on `CONFIG_XXX_CONSOLE` options but other use Kconfig `select CONFIG_XXX_CONSOLE` to mark that this device provides console. There is no consistency between drivers so fixing this is not that easy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
