jerpelea commented on pull request #288: URL: https://github.com/apache/incubator-nuttx-apps/pull/288#issuecomment-643171237
this commit is ok and you can understand what happened in that commit "libc: Add the remaining wscanf series declaration The function isn't implemented like other wide printf/scanf" this commit is not ok because there is no message (just the title) "arch/risc-v/src/k210: Add basic gpiohs support" This one is also slightly wrong because the title sentence was written on 2 lines and the second one became the commit message. "drivers/led: Let board_userled_initialize return the led number so the lower half driver don't need include the specific board.h" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
