yamt commented on code in PR #2456:
URL: https://github.com/apache/nuttx-apps/pull/2456#discussion_r1699875814
##########
nshlib/nsh_ddcmd.c:
##########
@@ -385,7 +385,7 @@ int cmd_dd(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char
**argv)
if (dd.skip)
{
ret = lseek(dd.infd, dd.skip * dd.sectsize, SEEK_SET);
- if (ret < -1)
+ if (ret < 0)
Review Comment:
> from https://pubs.opengroup.org/onlinepubs/009695399/functions/lseek.html,
the return value represents the absolute offset after seeking, why do we need
consider the returned value may be a negative value in success case?
you can do eg. `lseek(fd, -100, SEEK_SET)`.
for example, you may use negative offsets for /dev/kmem style character
devices.
note that on some platforms negative addresses are normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
