patacongo commented on a change in pull request #1233:
URL: https://github.com/apache/incubator-nuttx/pull/1233#discussion_r439830029



##########
File path: net/netdev/netdev_register.c
##########
@@ -313,6 +314,11 @@ int netdev_register(FAR struct net_driver_s *dev, enum 
net_lltype_e lltype)
             devfmt   = NETDEV_TUN_FORMAT;
             break;
 #endif
+        case NET_LL_MBIM:
+          dev->d_llhdrlen = 0;
+          dev->d_pktsize = 1200;
+          devfmt = NETDEV_MBIM_FORMAT;
+          break;

Review comment:
       Needs a change... the current logic does not write directly to dev, but 
sets a local variable.  This will not work.
   
   Appears to be an alignment problem with default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to