extinguish commented on code in PR #12846: URL: https://github.com/apache/nuttx/pull/12846#discussion_r1712594876
########## include/nuttx/compiler.h: ########## @@ -87,12 +87,21 @@ # define CONFIG_HAVE_CXX14 1 #endif +/* Green Hills Software definitions *****************************************/ + +#if defined(__ghs__) + +# pragma weak __gh_long_long_printf +# pragma weak __gh_float_printf + +#endif + /* GCC-specific definitions *************************************************/ #ifdef __GNUC__ /* Built-ins */ -# if __GNUC__ >= 4 +# if __GNUC__ >= 4 && !defined(__ghs__) Review Comment: > check ghs before **GNUC** this is invalid, cause we are using compatible GNUC mode, there are still some features that is needed for GNUC, if we remove this check, error will happen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
