extinguish commented on code in PR #12885:
URL: https://github.com/apache/nuttx/pull/12885#discussion_r1713298924


##########
include/nuttx/can.h:
##########
@@ -326,7 +326,7 @@ struct can_frame
   uint8_t  __pad;   /* padding */
   uint8_t  __res0;  /* reserved / padding */
   uint8_t  __res1;  /* reserved / padding */
-  uint8_t  data[CAN_MAX_DLEN] aligned_data(8);

Review Comment:
   > why needs this change?
   
   this is using to fix the following build error:
   CC:  src/algslib_sha256.c "comlin.c", line 189: error #1982-D: target stack 
alignment is insufficient to
             guarantee alignment of this variable
         struct can_frame lin_err_frame = comlin_rx_frame[chlId];
                          ^
   
   "comlin.c", line 282: error #1982-D: target stack alignment is insufficient 
to
             guarantee alignment of this variable
         struct can_frame frame;
                          ^
   
   "comlin.c", line 321: error #1982-D: target stack alignment is insufficient 
to
             guarantee alignment of this variable
         struct can_frame frame;
   
   "DiagServer_IsoTp.c", line 220: error #1982-D: target stack alignment is
             insufficient to guarantee alignment of this variable
         struct canfd_frame frame = {0};
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to