Meissi-jian commented on code in PR #12999:
URL: https://github.com/apache/nuttx/pull/12999#discussion_r1721650692


##########
net/tcp/tcp_input.c:
##########
@@ -1178,7 +1178,7 @@ static void tcp_input(FAR struct net_driver_s *dev, 
uint8_t domain,
                   return;
                 }
             }
-          else
+          else if ((conn->tcpstateflags & TCP_STATE_MASK) <= TCP_ESTABLISHED)

Review Comment:
   need goto Lin1220 and processed case TCP_FIN_WAIT ,so can't return in this 
case. what about this?
    ```
             else
               {
   #ifdef CONFIG_NET_TCP_OUT_OF_ORDER
                 /* Queue out-of-order segments. */
                 tcp_input_ofosegs(dev, conn, iplen);
   #endif
                 if ((conn->tcpstateflags & TCP_STATE_MASK) <= TCP_ESTABLISHED)
                   {
                     tcp_send(dev, conn, TCP_ACK, tcpiplen);
                     return;
                   }
              }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to