xiaoxiang781216 commented on code in PR #2508:
URL: https://github.com/apache/nuttx-apps/pull/2508#discussion_r1722205232
##########
netutils/iperf/CMakeLists.txt:
##########
@@ -30,7 +30,9 @@ if(CONFIG_NETUTILS_IPERF)
STACKSIZE
${CONFIG_NETUTILS_IPERF_STACKSIZE}
PRIORITY
- ${CONFIG_NETUTILS_IPERF_PRIORITY})
+ ${CONFIG_NETUTILS_IPERF_PRIORITY}
+ INCLUDE_DIRECTORIES
+ ${CMAKE_BINARY_DIR}/apps/include)
Review Comment:
should `${CMAKE_BINARY_DIR}/apps/include` add to the search path by
default? @xuxin930
##########
system/argtable3/CMakeLists.txt:
##########
@@ -82,6 +82,11 @@ if(CONFIG_SYSTEM_ARGTABLE3)
target_sources(argtable3 PRIVATE ${SRCS})
if(NOT EXISTS ${CMAKE_BINARY_DIR}/apps/include/argtable3.h)
+
+ if(NOT EXISTS ${CMAKE_BINARY_DIR}/apps/include)
Review Comment:
should we create `${CMAKE_BINARY_DIR}/apps/include` by default? @xuxin930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
