pietroalbini commented on code in PR #13086:
URL: https://github.com/apache/nuttx/pull/13086#discussion_r1726678583
##########
cmake/menuconfig.cmake:
##########
@@ -74,6 +74,24 @@ add_custom_target(
${NUTTX_DEFCONFIG}
WORKING_DIRECTORY ${NUTTX_DIR})
+add_custom_target(
+ oldconfig
+ COMMAND ${CMAKE_COMMAND} -E env ${KCONFIG_ENV} oldconfig
+ COMMAND ${CMAKE_COMMAND} -E remove -f
Review Comment:
Both the `oldconfig` and `olddefconfig` commands change the `.config` file,
but that doesn't automatically regenerate `include/nuttx/config.h`.
Looking at [this
comment](https://github.com/apache/nuttx/blob/fe642f1cfddfd89a713690bc67be614d402f4dcd/cmake/menuconfig.cmake#L21-L22),
it seems like proper dependency tracking to regenerate
`include/nuttx/config.h` when `.config` changes is not yet implemented. I took
both the commands you commented about from `menuconfig`.
This command specifically removes `include/nuttx/config.h` to force it being
regenerated at the next build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
