acassis commented on code in PR #13124: URL: https://github.com/apache/nuttx/pull/13124#discussion_r1729406983
########## boards/xtensa/esp32s3/common/src/esp32s3_lan9250.c: ########## @@ -62,6 +62,12 @@ static void lan9250_getmac(const struct lan9250_lower_s *lower, * Private Data ****************************************************************************/ +#ifdef CONFIG_LAN9250_SPI + static struct spi_dev_s *g_dev; +#else + static struct qspi_dev_s *g_dev; Review Comment: Why all the other LAN that not LAN9250 are supposed to be QSPI? It doesn't make much sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
