anchao commented on code in PR #2522: URL: https://github.com/apache/nuttx-apps/pull/2522#discussion_r1730047037
########## builtin/exec_builtin.c: ########## @@ -24,11 +24,11 @@ #include <nuttx/config.h> -#include <spawn.h> #include <fcntl.h> #include <errno.h> #include <debug.h> +#include "nshlib/nshlib.h" Review Comment: nshlib is just a library for the NuttX shell. I think it is not a good idea to reverse-use nshlib's APIs in builtin/system. They are not part of the shell. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
