This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/nuttx.git
commit d252b6229f069d43380f611da6b3a68a0dcebbed Author: Petro Karashchenko <[email protected]> AuthorDate: Sat Aug 24 12:54:12 2024 -0400 nuttx: use sizeof instead of define or number in snprintf Signed-off-by: Petro Karashchenko <[email protected]> --- Documentation/components/libs/libc/zoneinfo.rst | 2 +- arch/arm/src/lc823450/lc823450_mtd.c | 2 +- arch/arm/src/phy62xx/phyplus_stub.c | 4 ++-- arch/arm/src/phy62xx/phyplus_timer_lowerhalf.c | 6 ++---- arch/arm/src/s32k1xx/s32k1xx_eeeprom.c | 2 +- boards/arm/cxd56xx/common/src/cxd56_audio.c | 4 ++-- .../lc823450/lc823450-xgevk/src/lc823450_wm8776.c | 2 +- boards/arm/lpc31xx/ea3131/src/lpc31_fillpage.c | 3 ++- boards/arm/lpc31xx/ea3152/src/lpc31_fillpage.c | 3 ++- boards/arm/rp2040/common/src/rp2040_bmp180.c | 2 +- boards/arm/rp2040/common/src/rp2040_i2sdev.c | 2 +- boards/arm/rp2040/common/src/rp2040_ina219.c | 2 +- boards/arm/rp2040/common/src/rp2040_lcd_backpack.c | 2 +- boards/arm/rp2040/common/src/rp2040_max6675.c | 2 +- .../s32k1xx/rddrone-bms772/src/s32k1xx_smbus_sbd.c | 6 +++--- boards/arm/sama5/sama5d3x-ek/src/sam_wm8904.c | 2 +- boards/arm/sama5/sama5d4-ek/src/sam_audio_null.c | 2 +- boards/arm/sama5/sama5d4-ek/src/sam_wm8904.c | 2 +- boards/arm/samv7/samv71-xult/src/sam_audio_null.c | 2 +- boards/arm/samv7/samv71-xult/src/sam_wm8904.c | 2 +- boards/arm/stm32/axoloti/src/stm32_adau1961.c | 2 +- boards/arm/stm32/cloudctrl/src/stm32_w25.c | 2 +- boards/arm/stm32/common/src/board_hall3ph.c | 2 +- boards/arm/stm32/common/src/stm32_apa102.c | 2 +- boards/arm/stm32/common/src/stm32_apds9960.c | 2 +- boards/arm/stm32/common/src/stm32_bh1750.c | 2 +- boards/arm/stm32/common/src/stm32_bmp180.c | 2 +- boards/arm/stm32/common/src/stm32_dhtxx.c | 2 +- boards/arm/stm32/common/src/stm32_drv8825.c | 2 +- boards/arm/stm32/common/src/stm32_hcsr04.c | 2 +- boards/arm/stm32/common/src/stm32_ina219.c | 2 +- boards/arm/stm32/common/src/stm32_lcd_backpack.c | 2 +- boards/arm/stm32/common/src/stm32_lis3dsh.c | 2 +- boards/arm/stm32/common/src/stm32_lm75.c | 2 +- boards/arm/stm32/common/src/stm32_max31855.c | 2 +- boards/arm/stm32/common/src/stm32_max6675.c | 2 +- boards/arm/stm32/common/src/stm32_mlx90614.c | 2 +- boards/arm/stm32/common/src/stm32_mpl115a.c | 2 +- boards/arm/stm32/common/src/stm32_nunchuck.c | 2 +- boards/arm/stm32/common/src/stm32_qencoder.c | 2 +- boards/arm/stm32/common/src/stm32_tone.c | 2 +- boards/arm/stm32/common/src/stm32_veml6070.c | 2 +- boards/arm/stm32/common/src/stm32_ws2812.c | 2 +- boards/arm/stm32/fire-stm32v2/src/stm32_w25.c | 2 +- .../arm/stm32/olimex-stm32-p407/src/stm32_cs4344.c | 2 +- boards/arm/stm32/shenzhou/src/stm32_w25.c | 2 +- .../arm/stm32/stm32f4discovery/src/stm32_cs43l22.c | 2 +- boards/arm/stm32f7/common/src/stm32_cs4344.c | 2 +- .../arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c | 2 +- boards/arm/stm32h7/nucleo-h745zi/src/stm32_adc.c | 2 +- .../common/src/esp32c3_board_bmp180.c | 2 +- boards/risc-v/esp32c3/common/src/esp_board_bmp180.c | 2 +- boards/risc-v/esp32c6/common/src/esp_board_bmp180.c | 2 +- boards/risc-v/esp32h2/common/src/esp_board_bmp180.c | 2 +- boards/risc-v/litex/arty_a7/src/litex_pwm.c | 7 ++----- boards/sim/sim/sim/src/sim_zoneinfo.c | 2 +- boards/xtensa/esp32/common/src/esp32_bmp180.c | 2 +- boards/xtensa/esp32/common/src/esp32_cs4344.c | 2 +- boards/xtensa/esp32/common/src/esp32_lcd_backpack.c | 2 +- boards/xtensa/esp32/common/src/esp32_mcp2515.c | 2 +- boards/xtensa/esp32/common/src/esp32_sht3x.c | 2 +- boards/xtensa/esp32s2/common/src/esp32s2_cs4344.c | 2 +- .../xtensa/esp32s3/common/src/esp32s3_board_adc.c | 2 +- drivers/analog/hx711.c | 2 +- drivers/i2c/i2c_driver.c | 2 +- drivers/i2c/i2c_slave_driver.c | 2 +- drivers/i2s/i2schar.c | 2 +- drivers/ipcc/ipcc_register.c | 2 +- drivers/mmcsd/mmcsd_sdio.c | 2 +- drivers/mmcsd/mmcsd_spi.c | 2 +- drivers/mtd/smart.c | 21 +++++++++++++-------- drivers/rmt/rmtchar.c | 2 +- drivers/serial/pty.c | 14 +++++++------- drivers/spi/spi_driver.c | 2 +- drivers/usbdev/cdcacm.c | 4 ++-- drivers/usbdev/cdcncm.c | 2 +- drivers/video/fb.c | 4 ++-- drivers/virtio/virtio-snd.c | 4 ++-- fs/driver/fs_blockproxy.c | 3 ++- fs/driver/fs_mtdproxy.c | 3 ++- graphics/nxterm/nxterm_unregister.c | 2 +- libs/libc/stdlib/lib_openpty.c | 2 +- wireless/ieee802154/mac802154_device.c | 2 +- 83 files changed, 114 insertions(+), 110 deletions(-) diff --git a/Documentation/components/libs/libc/zoneinfo.rst b/Documentation/components/libs/libc/zoneinfo.rst index f068c711c7..e79da8818e 100644 --- a/Documentation/components/libs/libc/zoneinfo.rst +++ b/Documentation/components/libs/libc/zoneinfo.rst @@ -161,7 +161,7 @@ Sample Code to Mount the ROMFS Filesystem /* Use the minor number to create a name for the ROM disk block device */ - snprintf(devname, 32, "/dev/ram%d", minor); + snprintf(devname, sizeof(devname), "/dev/ram%d", minor); /* Mount the ROMFS file system */ diff --git a/arch/arm/src/lc823450/lc823450_mtd.c b/arch/arm/src/lc823450/lc823450_mtd.c index a33ccae0d0..ac494b452d 100644 --- a/arch/arm/src/lc823450/lc823450_mtd.c +++ b/arch/arm/src/lc823450/lc823450_mtd.c @@ -789,7 +789,7 @@ int lc823450_mtd_uninitialize(uint32_t devno) return -ENODEV; } - snprintf(devname, 16, "/dev/mtdblock%" PRId32, devno); + snprintf(devname, sizeof(devname), "/dev/mtdblock%" PRId32, devno); #ifdef CONFIG_MTD_REGISTRATION mtd_unregister(g_mtdmaster[ch]); diff --git a/arch/arm/src/phy62xx/phyplus_stub.c b/arch/arm/src/phy62xx/phyplus_stub.c index 0763b8bb8d..107c50a727 100644 --- a/arch/arm/src/phy62xx/phyplus_stub.c +++ b/arch/arm/src/phy62xx/phyplus_stub.c @@ -750,7 +750,7 @@ static int phyplus_stub_ioctl(struct file *filep, int cmd, int phyplus_stub_register(void) { char devname[16]; - snprintf(devname, 16, "/dev/phyplus"); + snprintf(devname, sizeof(devname), "/dev/phyplus"); return register_driver(devname, &g_stub_drvrops, 0666, NULL); } @@ -772,7 +772,7 @@ int phyplus_stub_register(void) void phyplus_stub_unregister(void) { char devname[16]; - snprintf(devname, 16, "/dev/phyplus"); + snprintf(devname, sizeof(devname), "/dev/phyplus"); unregister_driver(devname); } diff --git a/arch/arm/src/phy62xx/phyplus_timer_lowerhalf.c b/arch/arm/src/phy62xx/phyplus_timer_lowerhalf.c index b98769cff7..c6a0ec7221 100644 --- a/arch/arm/src/phy62xx/phyplus_timer_lowerhalf.c +++ b/arch/arm/src/phy62xx/phyplus_timer_lowerhalf.c @@ -596,18 +596,16 @@ static int phyplus_getstatus(struct timer_lowerhalf_s *lower, int phyplus_timer_register(struct phyplus_timer_param_s *phyplus_timer_param) { - const char *fmt; char devname[16]; - fmt = "/dev/timer%u"; - if ((phyplus_timer_param->timer_idx < 1) || (phyplus_timer_param->timer_idx > 6)) { return -ENODEV; } - snprintf(devname, 16, fmt, (unsigned int)phyplus_timer_param->timer_idx); + snprintf(devname, sizeof(devname), "/dev/timer%u", + phyplus_timer_param->timer_idx); return phyplus_timer_initialize(devname, phyplus_timer_param->timer_idx); } diff --git a/arch/arm/src/s32k1xx/s32k1xx_eeeprom.c b/arch/arm/src/s32k1xx/s32k1xx_eeeprom.c index ead54e6a6c..1b44026a09 100644 --- a/arch/arm/src/s32k1xx/s32k1xx_eeeprom.c +++ b/arch/arm/src/s32k1xx/s32k1xx_eeeprom.c @@ -403,7 +403,7 @@ int s32k1xx_eeeprom_register(int minor, uint32_t size) /* Create a eeeprom device name */ - snprintf(devname, 16, "/dev/eeeprom%d", minor); + snprintf(devname, sizeof(devname), "/dev/eeeprom%d", minor); /* Inode private data is a reference to the eeeprom device structure */ diff --git a/boards/arm/cxd56xx/common/src/cxd56_audio.c b/boards/arm/cxd56xx/common/src/cxd56_audio.c index 9ddb0821cc..0cdd773f36 100644 --- a/boards/arm/cxd56xx/common/src/cxd56_audio.c +++ b/boards/arm/cxd56xx/common/src/cxd56_audio.c @@ -499,7 +499,7 @@ int board_audio_initialize_driver(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the PCM/CXD56 audio device. */ @@ -524,7 +524,7 @@ int board_audio_initialize_driver(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm_in%d", minor); + snprintf(devname, sizeof(devname), "pcm_in%d", minor); /* Finally, we can register the CXD56 audio input device. */ diff --git a/boards/arm/lc823450/lc823450-xgevk/src/lc823450_wm8776.c b/boards/arm/lc823450/lc823450-xgevk/src/lc823450_wm8776.c index c58b2188d3..3e377708a0 100644 --- a/boards/arm/lc823450/lc823450-xgevk/src/lc823450_wm8776.c +++ b/boards/arm/lc823450/lc823450-xgevk/src/lc823450_wm8776.c @@ -108,7 +108,7 @@ int lc823450_wm8776initialize(int minor) return -ENODEV; } - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); ret = audio_register(devname, pcm); diff --git a/boards/arm/lpc31xx/ea3131/src/lpc31_fillpage.c b/boards/arm/lpc31xx/ea3131/src/lpc31_fillpage.c index f06e7aceb0..7b321b837a 100644 --- a/boards/arm/lpc31xx/ea3131/src/lpc31_fillpage.c +++ b/boards/arm/lpc31xx/ea3131/src/lpc31_fillpage.c @@ -256,7 +256,8 @@ static inline void lpc31_initsrc(void) /* Now mount the file system */ - snprintf(devname, 16, "/dev/mmcsd%d", CONFIG_EA3131_PAGING_MINOR); + snprintf(devname, sizeof(devname), "/dev/mmcsd%d", + CONFIG_EA3131_PAGING_MINOR); ret = nx_mount(devname, CONFIG_EA3131_PAGING_MOUNTPT, "vfat", MS_RDONLY, NULL); DEBUGASSERT(ret == OK); diff --git a/boards/arm/lpc31xx/ea3152/src/lpc31_fillpage.c b/boards/arm/lpc31xx/ea3152/src/lpc31_fillpage.c index 46bb94187f..bb297e2fce 100644 --- a/boards/arm/lpc31xx/ea3152/src/lpc31_fillpage.c +++ b/boards/arm/lpc31xx/ea3152/src/lpc31_fillpage.c @@ -257,7 +257,8 @@ static inline void lpc31_initsrc(void) /* Now mount the file system */ - snprintf(devname, 16, "/dev/mmcsd%d", CONFIG_EA3152_PAGING_MINOR); + snprintf(devname, sizeof(devname), "/dev/mmcsd%d", + CONFIG_EA3152_PAGING_MINOR); ret = nx_mount(devname, CONFIG_EA3152_PAGING_MOUNTPT, "vfat", MS_RDONLY, NULL); DEBUGASSERT(ret == OK); diff --git a/boards/arm/rp2040/common/src/rp2040_bmp180.c b/boards/arm/rp2040/common/src/rp2040_bmp180.c index 59bea0afae..a8aa0bc92d 100644 --- a/boards/arm/rp2040/common/src/rp2040_bmp180.c +++ b/boards/arm/rp2040/common/src/rp2040_bmp180.c @@ -93,7 +93,7 @@ int board_bmp180_initialize(int busno) { /* Then try to register the barometer sensor in I2C0 */ - snprintf(devpath, 12, "/dev/press%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/press%d", devno); ret = bmp180_register(devpath, i2c); if (ret < 0) { diff --git a/boards/arm/rp2040/common/src/rp2040_i2sdev.c b/boards/arm/rp2040/common/src/rp2040_i2sdev.c index 1b48dc6e84..183c394891 100644 --- a/boards/arm/rp2040/common/src/rp2040_i2sdev.c +++ b/boards/arm/rp2040/common/src/rp2040_i2sdev.c @@ -82,7 +82,7 @@ int board_i2sdev_initialize(int port) return -ENODEV; } - snprintf(devname, 12, "pcm%d", port); + snprintf(devname, sizeof(devname), "pcm%d", port); ret = audio_register(devname, pcm); diff --git a/boards/arm/rp2040/common/src/rp2040_ina219.c b/boards/arm/rp2040/common/src/rp2040_ina219.c index 13607a819a..caa5b94594 100644 --- a/boards/arm/rp2040/common/src/rp2040_ina219.c +++ b/boards/arm/rp2040/common/src/rp2040_ina219.c @@ -92,7 +92,7 @@ int board_ina219_initialize(int busno) /* Then register the sensor */ - snprintf(devpath, 14, "/dev/voltamp%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/voltamp%d", devno); ret = ina219_register(devpath, i2c, 0x40, 100000, 0x00); if (ret < 0) { diff --git a/boards/arm/rp2040/common/src/rp2040_lcd_backpack.c b/boards/arm/rp2040/common/src/rp2040_lcd_backpack.c index a488f7019c..771e32f0a5 100644 --- a/boards/arm/rp2040/common/src/rp2040_lcd_backpack.c +++ b/boards/arm/rp2040/common/src/rp2040_lcd_backpack.c @@ -86,7 +86,7 @@ int board_lcd_backpack_init(int devno, int busno, int rows, int cols) /* Register the Segment LCD */ - snprintf(devpath, 12, "/dev/slcd%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/slcd%d", devno); ret = pcf8574_lcd_backpack_register(devpath, i2c, &cfg); if (ret < 0) { diff --git a/boards/arm/rp2040/common/src/rp2040_max6675.c b/boards/arm/rp2040/common/src/rp2040_max6675.c index 5188118b30..7230da8d29 100644 --- a/boards/arm/rp2040/common/src/rp2040_max6675.c +++ b/boards/arm/rp2040/common/src/rp2040_max6675.c @@ -74,7 +74,7 @@ int board_max6675_initialize(int devno, int busno) /* Then register the temperature sensor */ - snprintf(devpath, 12, "/dev/temp%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/temp%d", devno); ret = max6675_register(devpath, spi); if (ret < 0) { diff --git a/boards/arm/s32k1xx/rddrone-bms772/src/s32k1xx_smbus_sbd.c b/boards/arm/s32k1xx/rddrone-bms772/src/s32k1xx_smbus_sbd.c index 0d48fb45a0..31acc5c919 100644 --- a/boards/arm/s32k1xx/rddrone-bms772/src/s32k1xx_smbus_sbd.c +++ b/boards/arm/s32k1xx/rddrone-bms772/src/s32k1xx_smbus_sbd.c @@ -770,7 +770,7 @@ int smbus_sbd_initialize(int minor, struct i2c_slave_s *i2c_slave_dev) { irqstate_t flags; struct smbus_sbd_dev_s *smbus_sbd_dev; - char dev_name[24]; + char devname[24]; int ret; /* Make sure the initialization is not interrupted */ @@ -789,13 +789,13 @@ int smbus_sbd_initialize(int minor, struct i2c_slave_s *i2c_slave_dev) { /* Create the device name string */ - snprintf(dev_name, 24, "/dev/smbus-sbd%d", minor); + snprintf(devname, sizeof(devname), "/dev/smbus-sbd%d", minor); /* Register the driver. The associated private data is a reference to * the SMBus Smart Battery Data slave device structure. */ - ret = register_driver(dev_name, &g_smbus_sbd_fops, 0, smbus_sbd_dev); + ret = register_driver(devname, &g_smbus_sbd_fops, 0, smbus_sbd_dev); if (ret < 0) { ferr("register_driver failed: %d\n", -ret); diff --git a/boards/arm/sama5/sama5d3x-ek/src/sam_wm8904.c b/boards/arm/sama5/sama5d3x-ek/src/sam_wm8904.c index bef50be7ae..dde2808e81 100644 --- a/boards/arm/sama5/sama5d3x-ek/src/sam_wm8904.c +++ b/boards/arm/sama5/sama5d3x-ek/src/sam_wm8904.c @@ -334,7 +334,7 @@ int sam_wm8904_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the PCM/WM8904/I2C/I2S audio device. * diff --git a/boards/arm/sama5/sama5d4-ek/src/sam_audio_null.c b/boards/arm/sama5/sama5d4-ek/src/sam_audio_null.c index 6e4a8ea3bc..c7428f9ad2 100644 --- a/boards/arm/sama5/sama5d4-ek/src/sam_audio_null.c +++ b/boards/arm/sama5/sama5d4-ek/src/sam_audio_null.c @@ -123,7 +123,7 @@ int sam_audio_null_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the PCM/NULL audio device. */ diff --git a/boards/arm/sama5/sama5d4-ek/src/sam_wm8904.c b/boards/arm/sama5/sama5d4-ek/src/sam_wm8904.c index 56b05922f7..005cca295b 100644 --- a/boards/arm/sama5/sama5d4-ek/src/sam_wm8904.c +++ b/boards/arm/sama5/sama5d4-ek/src/sam_wm8904.c @@ -334,7 +334,7 @@ int sam_wm8904_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the PCM/WM8904/I2C/I2S audio device. * diff --git a/boards/arm/samv7/samv71-xult/src/sam_audio_null.c b/boards/arm/samv7/samv71-xult/src/sam_audio_null.c index a78f1fc0f7..8acc27cbb5 100644 --- a/boards/arm/samv7/samv71-xult/src/sam_audio_null.c +++ b/boards/arm/samv7/samv71-xult/src/sam_audio_null.c @@ -123,7 +123,7 @@ int sam_audio_null_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the PCM/NULL audio device. */ diff --git a/boards/arm/samv7/samv71-xult/src/sam_wm8904.c b/boards/arm/samv7/samv71-xult/src/sam_wm8904.c index ae7560b223..bb7cb57522 100644 --- a/boards/arm/samv7/samv71-xult/src/sam_wm8904.c +++ b/boards/arm/samv7/samv71-xult/src/sam_wm8904.c @@ -334,7 +334,7 @@ int sam_wm8904_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the PCM/WM8904/I2C/I2S audio device. * diff --git a/boards/arm/stm32/axoloti/src/stm32_adau1961.c b/boards/arm/stm32/axoloti/src/stm32_adau1961.c index 9b5a21e538..4c4fba9736 100644 --- a/boards/arm/stm32/axoloti/src/stm32_adau1961.c +++ b/boards/arm/stm32/axoloti/src/stm32_adau1961.c @@ -178,7 +178,7 @@ int stm32_adau1961_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the ADAU1961/I2C/I2S audio device. */ diff --git a/boards/arm/stm32/cloudctrl/src/stm32_w25.c b/boards/arm/stm32/cloudctrl/src/stm32_w25.c index 570d8b9a78..ae309b5af9 100644 --- a/boards/arm/stm32/cloudctrl/src/stm32_w25.c +++ b/boards/arm/stm32/cloudctrl/src/stm32_w25.c @@ -125,7 +125,7 @@ int stm32_w25initialize(int minor) /* Mount the file system at /mnt/w25 */ - snprintf(devname, 12, "/mnt/w25%c", 'a' + minor); + snprintf(devname, sizeof(devname), "/mnt/w25%c", 'a' + minor); ret = nx_mount(NULL, devname, "nxffs", 0, NULL); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/board_hall3ph.c b/boards/arm/stm32/common/src/board_hall3ph.c index 913d0fc3d7..ad0790eaef 100644 --- a/boards/arm/stm32/common/src/board_hall3ph.c +++ b/boards/arm/stm32/common/src/board_hall3ph.c @@ -63,7 +63,7 @@ int board_hall3ph_initialize(int devno, int pha, int phb, int phc) /* Initialize a Hall effect sensor interface. */ - snprintf(devpath, 12, "/dev/hall%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/hall%d", devno); ret = stm32_hall3ph_initialize(devpath, &cfg); if (ret < 0) diff --git a/boards/arm/stm32/common/src/stm32_apa102.c b/boards/arm/stm32/common/src/stm32_apa102.c index 3f37ab891a..b3eedc7d25 100644 --- a/boards/arm/stm32/common/src/stm32_apa102.c +++ b/boards/arm/stm32/common/src/stm32_apa102.c @@ -93,7 +93,7 @@ int board_apa102_initialize(int devno, int spino) /* Register the APA102 Driver at the specified location. */ - snprintf(devpath, 13, "/dev/leddrv%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/leddrv%d", devno); ret = apa102_register(devpath, spi); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_apds9960.c b/boards/arm/stm32/common/src/stm32_apds9960.c index 3f5f5be6b1..1513330b8d 100644 --- a/boards/arm/stm32/common/src/stm32_apds9960.c +++ b/boards/arm/stm32/common/src/stm32_apds9960.c @@ -154,7 +154,7 @@ int board_apds9960_initialize(int devno, int busno) /* Then register the gesture sensor */ - snprintf(devpath, 12, "/dev/gest%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/gest%d", devno); ret = apds9960_register(devpath, &g_apds9960config.config); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_bh1750.c b/boards/arm/stm32/common/src/stm32_bh1750.c index 612ded26b5..ec16aa7d7f 100644 --- a/boards/arm/stm32/common/src/stm32_bh1750.c +++ b/boards/arm/stm32/common/src/stm32_bh1750.c @@ -76,7 +76,7 @@ int board_bh1750_initialize(int devno, int busno) /* Then register the ambient light sensor */ - snprintf(devpath, 12, "/dev/light%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/light%d", devno); ret = bh1750fvi_register(devpath, i2c, BH1750FVI_I2C_ADDR); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_bmp180.c b/boards/arm/stm32/common/src/stm32_bmp180.c index 5cae7288d6..72a222968e 100644 --- a/boards/arm/stm32/common/src/stm32_bmp180.c +++ b/boards/arm/stm32/common/src/stm32_bmp180.c @@ -92,7 +92,7 @@ int board_bmp180_initialize(int devno, int busno) /* Then register the barometer sensor */ - snprintf(devpath, 12, "/dev/press%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/press%d", devno); ret = bmp180_register(devpath, i2c); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_dhtxx.c b/boards/arm/stm32/common/src/stm32_dhtxx.c index 37f50eeccb..cd92b6061b 100644 --- a/boards/arm/stm32/common/src/stm32_dhtxx.c +++ b/boards/arm/stm32/common/src/stm32_dhtxx.c @@ -143,7 +143,7 @@ int board_dhtxx_initialize(int devno) return -ENODEV; } - snprintf(devpath, 12, "/dev/hum%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/hum%d", devno); ret = dhtxx_register(devpath, &g_dhtxx_config); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_drv8825.c b/boards/arm/stm32/common/src/stm32_drv8825.c index 28fe8f402c..9e597658a8 100644 --- a/boards/arm/stm32/common/src/stm32_drv8825.c +++ b/boards/arm/stm32/common/src/stm32_drv8825.c @@ -190,7 +190,7 @@ int board_drv8825_initialize(int devno) drv8825_initialize(); - snprintf(devname, 15, "/dev/stepper%d", devno); + snprintf(devname, sizeof(devname), "/dev/stepper%d", devno); ret = drv8825_register(devname, &g_drv8825_ops); diff --git a/boards/arm/stm32/common/src/stm32_hcsr04.c b/boards/arm/stm32/common/src/stm32_hcsr04.c index c18c08b326..17eec94b3a 100644 --- a/boards/arm/stm32/common/src/stm32_hcsr04.c +++ b/boards/arm/stm32/common/src/stm32_hcsr04.c @@ -241,6 +241,6 @@ int board_hcsr04_initialize(int devno) return -ENODEV; } - snprintf(devpath, 12, "/dev/dist%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/dist%d", devno); return hcsr04_register(devpath, &g_hcsr04config.config); } diff --git a/boards/arm/stm32/common/src/stm32_ina219.c b/boards/arm/stm32/common/src/stm32_ina219.c index 16cddb37e6..4b557dccd8 100644 --- a/boards/arm/stm32/common/src/stm32_ina219.c +++ b/boards/arm/stm32/common/src/stm32_ina219.c @@ -93,7 +93,7 @@ int board_ina219_initialize(int devno, int busno) /* Then register the sensor */ - snprintf(devpath, 12, "/dev/ina%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/ina%d", devno); ret = ina219_register(devpath, i2c, 0x40, 100000, 0x00); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_lcd_backpack.c b/boards/arm/stm32/common/src/stm32_lcd_backpack.c index d7a75e2fa8..f811e7d8e1 100644 --- a/boards/arm/stm32/common/src/stm32_lcd_backpack.c +++ b/boards/arm/stm32/common/src/stm32_lcd_backpack.c @@ -84,7 +84,7 @@ int board_lcd_backpack_init(int devno, int busno, int rows, int cols) /* Register the Segment LCD */ - snprintf(devpath, 12, "/dev/slcd%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/slcd%d", devno); ret = pcf8574_lcd_backpack_register(devpath, i2c, &cfg); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_lis3dsh.c b/boards/arm/stm32/common/src/stm32_lis3dsh.c index b57067ee8d..bbd89d55c4 100644 --- a/boards/arm/stm32/common/src/stm32_lis3dsh.c +++ b/boards/arm/stm32/common/src/stm32_lis3dsh.c @@ -107,7 +107,7 @@ int board_lis3dsh_initialize(int devno, int busno) } else { - snprintf(devpath, 12, "/dev/acc%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/acc%d", devno); ret = lis3dsh_register(devpath, spi, &acc0_config); } diff --git a/boards/arm/stm32/common/src/stm32_lm75.c b/boards/arm/stm32/common/src/stm32_lm75.c index ee9751ad81..8d6ae903a2 100644 --- a/boards/arm/stm32/common/src/stm32_lm75.c +++ b/boards/arm/stm32/common/src/stm32_lm75.c @@ -92,7 +92,7 @@ int board_lm75_initialize(int devno, int busno) /* Then register the temperature sensor */ - snprintf(devpath, 12, "/dev/temp%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/temp%d", devno); ret = lm75_register(devpath, i2c, 0x48); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_max31855.c b/boards/arm/stm32/common/src/stm32_max31855.c index cd5dac76fc..8ec569dc6f 100644 --- a/boards/arm/stm32/common/src/stm32_max31855.c +++ b/boards/arm/stm32/common/src/stm32_max31855.c @@ -69,7 +69,7 @@ int board_max31855_initialize(int devno, int busno) /* Then register the temperature sensor */ - snprintf(devpath, 12, "/dev/temp%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/temp%d", devno); ret = max31855_register(devpath, spi, devno); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_max6675.c b/boards/arm/stm32/common/src/stm32_max6675.c index 19c7b26cd7..6c4befa06c 100644 --- a/boards/arm/stm32/common/src/stm32_max6675.c +++ b/boards/arm/stm32/common/src/stm32_max6675.c @@ -90,7 +90,7 @@ int board_max6675_initialize(int devno, int busno) /* Then register the temperature sensor */ - snprintf(devpath, 12, "/dev/temp%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/temp%d", devno); ret = max6675_register(devpath, spi); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_mlx90614.c b/boards/arm/stm32/common/src/stm32_mlx90614.c index f497eb4753..4b1e6b5d6e 100644 --- a/boards/arm/stm32/common/src/stm32_mlx90614.c +++ b/boards/arm/stm32/common/src/stm32_mlx90614.c @@ -78,7 +78,7 @@ int board_mlx90614_initialize(int devno, int busno) /* Then register the Infrared Thermometer sensor */ - snprintf(devpath, 12, "/dev/therm%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/therm%d", devno); ret = mlx90614_register(devpath, i2c, MLX90614_ADDRESS); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_mpl115a.c b/boards/arm/stm32/common/src/stm32_mpl115a.c index 3bf0e89647..00bb2def06 100644 --- a/boards/arm/stm32/common/src/stm32_mpl115a.c +++ b/boards/arm/stm32/common/src/stm32_mpl115a.c @@ -72,7 +72,7 @@ int board_mpl115a_initialize(int devno, int busno) /* Then register the barometer sensor */ - snprintf(devpath, 12, "/dev/press%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/press%d", devno); ret = mpl115a_register(devpath, spi); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_nunchuck.c b/boards/arm/stm32/common/src/stm32_nunchuck.c index 31259d14d7..d8bc0df3e7 100644 --- a/boards/arm/stm32/common/src/stm32_nunchuck.c +++ b/boards/arm/stm32/common/src/stm32_nunchuck.c @@ -98,7 +98,7 @@ int board_nunchuck_initialize(int devno, int busno) /* Register the joystick device as /dev/nunchuck0 */ - snprintf(devpath, 15, "/dev/nunchuck%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/nunchuck%d", devno); iinfo("Initialize joystick driver: %s\n", devpath); ret = nunchuck_register(devpath, i2c); diff --git a/boards/arm/stm32/common/src/stm32_qencoder.c b/boards/arm/stm32/common/src/stm32_qencoder.c index 0a31bc9ee1..3a53d055fb 100644 --- a/boards/arm/stm32/common/src/stm32_qencoder.c +++ b/boards/arm/stm32/common/src/stm32_qencoder.c @@ -55,7 +55,7 @@ int board_qencoder_initialize(int devno, int timerno) /* Initialize a quadrature encoder interface. */ sninfo("Initializing the quadrature encoder using TIM%d\n", timerno); - snprintf(devpath, 12, "/dev/qe%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/qe%d", devno); ret = stm32_qeinitialize(devpath, timerno); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_tone.c b/boards/arm/stm32/common/src/stm32_tone.c index bbb0d6994f..1980d7b5e2 100644 --- a/boards/arm/stm32/common/src/stm32_tone.c +++ b/boards/arm/stm32/common/src/stm32_tone.c @@ -115,7 +115,7 @@ int board_tone_initialize(int devno) /* Register the Audio Tone driver at "/dev/tone0" */ - snprintf(devpath, 12, "/dev/tone%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/tone%d", devno); ret = tone_register(devpath, tone, oneshot); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_veml6070.c b/boards/arm/stm32/common/src/stm32_veml6070.c index 613d6f6d69..c30e9b2605 100644 --- a/boards/arm/stm32/common/src/stm32_veml6070.c +++ b/boards/arm/stm32/common/src/stm32_veml6070.c @@ -99,7 +99,7 @@ int board_veml6070_initialize(int devno, int busno) /* Then register the light sensor */ - snprintf(devpath, 14, "/dev/uvlight%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/uvlight%d", devno); ret = veml6070_register(devpath, i2c, VEML6070_I2C_DATA_LSB_CMD_ADDR); if (ret < 0) { diff --git a/boards/arm/stm32/common/src/stm32_ws2812.c b/boards/arm/stm32/common/src/stm32_ws2812.c index 9b5cd5eb78..3e0ca54fc9 100644 --- a/boards/arm/stm32/common/src/stm32_ws2812.c +++ b/boards/arm/stm32/common/src/stm32_ws2812.c @@ -94,7 +94,7 @@ int board_ws2812_initialize(int devno, int spino, uint16_t nleds) /* Register the WS2812 driver at the specified location. */ - snprintf(devpath, 13, "/dev/leddrv%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/leddrv%d", devno); ret = ws2812_leds_register(devpath, spi, nleds); if (ret < 0) { diff --git a/boards/arm/stm32/fire-stm32v2/src/stm32_w25.c b/boards/arm/stm32/fire-stm32v2/src/stm32_w25.c index da6810905d..be5a66bb12 100644 --- a/boards/arm/stm32/fire-stm32v2/src/stm32_w25.c +++ b/boards/arm/stm32/fire-stm32v2/src/stm32_w25.c @@ -125,7 +125,7 @@ int stm32_w25initialize(int minor) /* Mount the file system at /mnt/w25 */ - snprintf(devname, 12, "/mnt/w25%c", 'a' + minor); + snprintf(devname, sizeof(devname), "/mnt/w25%c", 'a' + minor); ret = nx_mount(NULL, devname, "nxffs", 0, NULL); if (ret < 0) { diff --git a/boards/arm/stm32/olimex-stm32-p407/src/stm32_cs4344.c b/boards/arm/stm32/olimex-stm32-p407/src/stm32_cs4344.c index d0d16233b4..7e3542dcf3 100644 --- a/boards/arm/stm32/olimex-stm32-p407/src/stm32_cs4344.c +++ b/boards/arm/stm32/olimex-stm32-p407/src/stm32_cs4344.c @@ -141,7 +141,7 @@ int stm32_cs4344_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the PCM/CS4344/I2S audio device. * diff --git a/boards/arm/stm32/shenzhou/src/stm32_w25.c b/boards/arm/stm32/shenzhou/src/stm32_w25.c index c6ffead272..96443aed70 100644 --- a/boards/arm/stm32/shenzhou/src/stm32_w25.c +++ b/boards/arm/stm32/shenzhou/src/stm32_w25.c @@ -126,7 +126,7 @@ int stm32_w25initialize(int minor) /* Mount the file system at /mnt/w25 */ - snprintf(devname, 12, "/mnt/w25%c", 'a' + minor); + snprintf(devname, sizeof(devname), "/mnt/w25%c", 'a' + minor); ret = nx_mount(NULL, devname, "nxffs", 0, NULL); if (ret < 0) { diff --git a/boards/arm/stm32/stm32f4discovery/src/stm32_cs43l22.c b/boards/arm/stm32/stm32f4discovery/src/stm32_cs43l22.c index 60602fc43b..4bf6a67fe6 100644 --- a/boards/arm/stm32/stm32f4discovery/src/stm32_cs43l22.c +++ b/boards/arm/stm32/stm32f4discovery/src/stm32_cs43l22.c @@ -342,7 +342,7 @@ int stm32_cs43l22_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the PCM/CS43L22/I2C/I2S audio device. * diff --git a/boards/arm/stm32f7/common/src/stm32_cs4344.c b/boards/arm/stm32f7/common/src/stm32_cs4344.c index 221cc7fd69..6d52353e83 100644 --- a/boards/arm/stm32f7/common/src/stm32_cs4344.c +++ b/boards/arm/stm32f7/common/src/stm32_cs4344.c @@ -140,7 +140,7 @@ int board_cs4344_initialize(int devno, int port) /* Create a device name */ - snprintf(devname, 12, "pcm%d", devno); + snprintf(devname, sizeof(devname), "pcm%d", devno); /* Finally, we can register the PCM/CS4344/I2S audio device. * diff --git a/boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c b/boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c index 6518ab90ea..eab931cae4 100644 --- a/boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c +++ b/boards/arm/stm32f7/stm32f746g-disco/src/stm32_wm8994.c @@ -286,7 +286,7 @@ int stm32_wm8994_initialize(int minor) /* Create a device name */ - snprintf(devname, 12, "pcm%d", minor); + snprintf(devname, sizeof(devname), "pcm%d", minor); /* Finally, we can register the ADAU1961/I2C/I2S audio device. */ diff --git a/boards/arm/stm32h7/nucleo-h745zi/src/stm32_adc.c b/boards/arm/stm32h7/nucleo-h745zi/src/stm32_adc.c index e5c80f4073..5c1a4217c8 100644 --- a/boards/arm/stm32h7/nucleo-h745zi/src/stm32_adc.c +++ b/boards/arm/stm32h7/nucleo-h745zi/src/stm32_adc.c @@ -142,7 +142,7 @@ int stm32_adc_setup(int adcno) if (!initialized) { - snprintf(devname, 1, "/dev/adc%d", adcno); + snprintf(devname, sizeof(devname), "/dev/adc%d", adcno); #endif #if defined(CONFIG_STM32H7_ADC1) diff --git a/boards/risc-v/esp32c3-legacy/common/src/esp32c3_board_bmp180.c b/boards/risc-v/esp32c3-legacy/common/src/esp32c3_board_bmp180.c index 9f223bbac8..889f9e0df8 100644 --- a/boards/risc-v/esp32c3-legacy/common/src/esp32c3_board_bmp180.c +++ b/boards/risc-v/esp32c3-legacy/common/src/esp32c3_board_bmp180.c @@ -70,7 +70,7 @@ int board_bmp180_initialize(int devno, int busno) { /* Then try to register the barometer sensor in I2C0 */ - snprintf(devpath, 12, "/dev/press%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/press%d", devno); ret = bmp180_register(devpath, i2c); if (ret < 0) { diff --git a/boards/risc-v/esp32c3/common/src/esp_board_bmp180.c b/boards/risc-v/esp32c3/common/src/esp_board_bmp180.c index 1748214a93..4161a9e77f 100644 --- a/boards/risc-v/esp32c3/common/src/esp_board_bmp180.c +++ b/boards/risc-v/esp32c3/common/src/esp_board_bmp180.c @@ -70,7 +70,7 @@ int board_bmp180_initialize(int devno) { /* Then try to register the barometer sensor in I2C0 */ - snprintf(devpath, 12, "/dev/press%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/press%d", devno); ret = bmp180_register(devpath, i2c); if (ret < 0) { diff --git a/boards/risc-v/esp32c6/common/src/esp_board_bmp180.c b/boards/risc-v/esp32c6/common/src/esp_board_bmp180.c index d6f3f3177a..b9327dedd3 100644 --- a/boards/risc-v/esp32c6/common/src/esp_board_bmp180.c +++ b/boards/risc-v/esp32c6/common/src/esp_board_bmp180.c @@ -70,7 +70,7 @@ int board_bmp180_initialize(int devno) { /* Then try to register the barometer sensor in I2C0 */ - snprintf(devpath, 12, "/dev/press%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/press%d", devno); ret = bmp180_register(devpath, i2c); if (ret < 0) { diff --git a/boards/risc-v/esp32h2/common/src/esp_board_bmp180.c b/boards/risc-v/esp32h2/common/src/esp_board_bmp180.c index 559a5d4458..616a65b237 100644 --- a/boards/risc-v/esp32h2/common/src/esp_board_bmp180.c +++ b/boards/risc-v/esp32h2/common/src/esp_board_bmp180.c @@ -69,7 +69,7 @@ int board_bmp180_initialize(int devno) { /* Then try to register the barometer sensor in I2C0 */ - snprintf(devpath, 12, "/dev/press%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/press%d", devno); ret = bmp180_register(devpath, i2c); if (ret < 0) { diff --git a/boards/risc-v/litex/arty_a7/src/litex_pwm.c b/boards/risc-v/litex/arty_a7/src/litex_pwm.c index df32534fbc..c61eb49f2e 100644 --- a/boards/risc-v/litex/arty_a7/src/litex_pwm.c +++ b/boards/risc-v/litex/arty_a7/src/litex_pwm.c @@ -60,10 +60,7 @@ int litex_pwm_setup(void) struct pwm_lowerhalf_s *pwm = NULL; int ret = OK; int channel; - char devpath[12] = - { - 0 - }; + char devpath[12]; for (channel = 0; channel < LITEX_PWM_MAX; channel++) { @@ -76,7 +73,7 @@ int litex_pwm_setup(void) /* Register the PWM driver at "/dev/pwmX" */ - snprintf(devpath, 12, "/dev/pwm%d", channel); + snprintf(devpath, sizeof(devpath), "/dev/pwm%d", channel); ret = pwm_register(devpath, pwm); if (ret < 0) { diff --git a/boards/sim/sim/sim/src/sim_zoneinfo.c b/boards/sim/sim/sim/src/sim_zoneinfo.c index ff33122e9b..a6dc4269cc 100644 --- a/boards/sim/sim/sim/src/sim_zoneinfo.c +++ b/boards/sim/sim/sim/src/sim_zoneinfo.c @@ -113,7 +113,7 @@ int sim_zoneinfo(int minor) /* Use the minor number to create a name for the ROM disk block device */ - snprintf(devname, 32, "/dev/ram%d", minor); + snprintf(devname, sizeof(devname), "/dev/ram%d", minor); /* Mount the ROMFS file system */ diff --git a/boards/xtensa/esp32/common/src/esp32_bmp180.c b/boards/xtensa/esp32/common/src/esp32_bmp180.c index 6cf195ab83..17822235b4 100644 --- a/boards/xtensa/esp32/common/src/esp32_bmp180.c +++ b/boards/xtensa/esp32/common/src/esp32_bmp180.c @@ -94,7 +94,7 @@ int board_bmp180_initialize(int devno, int busno) { /* Then try to register the barometer sensor in I2C0 */ - snprintf(devpath, 12, "/dev/press%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/press%d", devno); ret = bmp180_register(devpath, i2c); if (ret < 0) { diff --git a/boards/xtensa/esp32/common/src/esp32_cs4344.c b/boards/xtensa/esp32/common/src/esp32_cs4344.c index 76487cafe2..6fe6c5d485 100644 --- a/boards/xtensa/esp32/common/src/esp32_cs4344.c +++ b/boards/xtensa/esp32/common/src/esp32_cs4344.c @@ -137,7 +137,7 @@ int esp32_cs4344_initialize(int port) /* Create a device name */ - snprintf(devname, 12, "pcm%d", port); + snprintf(devname, sizeof(devname), "pcm%d", port); /* Finally, we can register the PCM/CS4344/I2S audio device. * diff --git a/boards/xtensa/esp32/common/src/esp32_lcd_backpack.c b/boards/xtensa/esp32/common/src/esp32_lcd_backpack.c index 88d802084b..66d5d8a0f7 100644 --- a/boards/xtensa/esp32/common/src/esp32_lcd_backpack.c +++ b/boards/xtensa/esp32/common/src/esp32_lcd_backpack.c @@ -85,7 +85,7 @@ int board_lcd_backpack_init(int devno, int busno, int rows, int cols) /* Register the Segment LCD */ - snprintf(devpath, 12, "/dev/slcd%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/slcd%d", devno); ret = pcf8574_lcd_backpack_register(devpath, i2c, &cfg); if (ret < 0) { diff --git a/boards/xtensa/esp32/common/src/esp32_mcp2515.c b/boards/xtensa/esp32/common/src/esp32_mcp2515.c index ef4677301b..4ecef46241 100644 --- a/boards/xtensa/esp32/common/src/esp32_mcp2515.c +++ b/boards/xtensa/esp32/common/src/esp32_mcp2515.c @@ -242,7 +242,7 @@ int board_mcp2515_initialize(int devno) /* Create the '/dev/canX' name based on 'devno' */ - snprintf(devpath, 10, "/dev/can%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/can%d", devno); /* Register the CAN driver at "/dev/can0" */ diff --git a/boards/xtensa/esp32/common/src/esp32_sht3x.c b/boards/xtensa/esp32/common/src/esp32_sht3x.c index 3656da7e87..0f10949b76 100644 --- a/boards/xtensa/esp32/common/src/esp32_sht3x.c +++ b/boards/xtensa/esp32/common/src/esp32_sht3x.c @@ -96,7 +96,7 @@ int board_sht3x_initialize(int devno, int busno) { /* Then try to register the sensor in I2C Bus */ - snprintf(devpath, 12, "/dev/temp%d", devno); + snprintf(devpath, sizeof(devpath), "/dev/temp%d", devno); ret = sht3x_register(devpath, i2c, SHT3X_I2CADDR); if (ret < 0) { diff --git a/boards/xtensa/esp32s2/common/src/esp32s2_cs4344.c b/boards/xtensa/esp32s2/common/src/esp32s2_cs4344.c index 57f39a8f9b..ef314013b6 100644 --- a/boards/xtensa/esp32s2/common/src/esp32s2_cs4344.c +++ b/boards/xtensa/esp32s2/common/src/esp32s2_cs4344.c @@ -131,7 +131,7 @@ int esp32s2_cs4344_initialize(void) /* Create a device name */ - snprintf(devname, 12, "pcm0"); + snprintf(devname, sizeof(devname), "pcm0"); /* Finally, we can register the PCM/CS4344/I2S audio device. * diff --git a/boards/xtensa/esp32s3/common/src/esp32s3_board_adc.c b/boards/xtensa/esp32s3/common/src/esp32s3_board_adc.c index 5093eca274..3d940064bf 100644 --- a/boards/xtensa/esp32s3/common/src/esp32s3_board_adc.c +++ b/boards/xtensa/esp32s3/common/src/esp32s3_board_adc.c @@ -70,7 +70,7 @@ static int board_adc_register(int channel) memset(adcdev, 0, sizeof(struct adc_dev_s)); esp32s3_adc_init(channel, adcdev); - snprintf(devname, 12, "/dev/adc%d", channel); + snprintf(devname, sizeof(devname), "/dev/adc%d", channel); /* Register the ADC driver at "/dev/adcx_x" */ diff --git a/drivers/analog/hx711.c b/drivers/analog/hx711.c index 089a780743..8fda40d568 100644 --- a/drivers/analog/hx711.c +++ b/drivers/analog/hx711.c @@ -946,7 +946,7 @@ int hx711_register(unsigned char minor, FAR struct hx711_lower_s *lower) return -ENOMEM; } - snprintf(devname, DEVNAME_FMTLEN, DEVNAME_FMT, minor); + snprintf(devname, sizeof(devname), DEVNAME_FMT, minor); ret = register_driver(devname, &g_hx711_fops, 0666, dev); if (ret) { diff --git a/drivers/i2c/i2c_driver.c b/drivers/i2c/i2c_driver.c index 1a78a64b2d..888a323caf 100644 --- a/drivers/i2c/i2c_driver.c +++ b/drivers/i2c/i2c_driver.c @@ -407,7 +407,7 @@ int i2c_register(FAR struct i2c_master_s *i2c, int bus) /* Create the character device name */ - snprintf(devname, DEVNAME_FMTLEN, DEVNAME_FMT, bus); + snprintf(devname, sizeof(devname), DEVNAME_FMT, bus); ret = register_driver(devname, &g_i2cdrvr_fops, 0666, priv); if (ret < 0) { diff --git a/drivers/i2c/i2c_slave_driver.c b/drivers/i2c/i2c_slave_driver.c index 79ade78f6f..b71c1266cc 100644 --- a/drivers/i2c/i2c_slave_driver.c +++ b/drivers/i2c/i2c_slave_driver.c @@ -559,7 +559,7 @@ int i2c_slave_register(FAR struct i2c_slave_s *dev, int bus, int addr, return -ENOMEM; } - snprintf(devname, DEVNAME_FMTLEN, DEVNAME_FMT, bus); + snprintf(devname, sizeof(devname), DEVNAME_FMT, bus); ret = register_driver(devname, &g_i2cslavefops, 0666, priv); if (ret < 0) { diff --git a/drivers/i2s/i2schar.c b/drivers/i2s/i2schar.c index 5955706c90..67744668a4 100644 --- a/drivers/i2s/i2schar.c +++ b/drivers/i2s/i2schar.c @@ -419,7 +419,7 @@ int i2schar_register(FAR struct i2s_dev_s *i2s, int minor) /* Create the character device name */ - snprintf(devname, DEVNAME_FMTLEN, DEVNAME_FMT, minor); + snprintf(devname, sizeof(devname), DEVNAME_FMT, minor); ret = register_driver(devname, &g_i2schar_fops, 0666, priv); if (ret < 0) { diff --git a/drivers/ipcc/ipcc_register.c b/drivers/ipcc/ipcc_register.c index d15564df12..46644f4b91 100644 --- a/drivers/ipcc/ipcc_register.c +++ b/drivers/ipcc/ipcc_register.c @@ -164,7 +164,7 @@ int ipcc_register(FAR struct ipcc_lower_s *ipcc) /* Create the character device name */ - snprintf(devname, DEVNAME_FMTLEN, DEVNAME_FMT, ipcc->chan); + snprintf(devname, sizeof(devname), DEVNAME_FMT, ipcc->chan); if ((ret = register_driver(devname, &g_ipcc_fops, 0666, priv))) { goto error; diff --git a/drivers/mmcsd/mmcsd_sdio.c b/drivers/mmcsd/mmcsd_sdio.c index b966b9a2df..0e851023b5 100644 --- a/drivers/mmcsd/mmcsd_sdio.c +++ b/drivers/mmcsd/mmcsd_sdio.c @@ -4208,7 +4208,7 @@ int mmcsd_slotinitialize(int minor, FAR struct sdio_dev_s *dev) /* Create a MMCSD device name */ - snprintf(devname, 16, "/dev/mmcsd%d", minor); + snprintf(devname, sizeof(devname), "/dev/mmcsd%d", minor); /* Inode private data is a reference to the MMCSD state structure */ diff --git a/drivers/mmcsd/mmcsd_spi.c b/drivers/mmcsd/mmcsd_spi.c index fb911d5a63..8162c094b8 100644 --- a/drivers/mmcsd/mmcsd_spi.c +++ b/drivers/mmcsd/mmcsd_spi.c @@ -2074,7 +2074,7 @@ int mmcsd_spislotinitialize(int minor, int slotno, FAR struct spi_dev_s *spi) /* Create a MMC/SD device name */ - snprintf(devname, 16, "/dev/mmcsd%d", minor); + snprintf(devname, sizeof(devname), "/dev/mmcsd%d", minor); /* Register the driver, even on a failure condition. A * card may be inserted later, for example. diff --git a/drivers/mtd/smart.c b/drivers/mtd/smart.c index 5b3493acb6..97d0dc8cc0 100644 --- a/drivers/mtd/smart.c +++ b/drivers/mtd/smart.c @@ -3311,8 +3311,9 @@ static inline int smart_llformat(FAR struct smart_struct_s *dev, for (x = 2; x < 8; x++) { - snprintf(dev->rwbuffer, 18, "/dev/smart%dd%d", dev->minor, x); - unregister_blockdriver(dev->rwbuffer); + char devname[18]; + snprintf(devname, sizeof(devname), "/dev/smart%dd%d", dev->minor, x); + unregister_blockdriver(devname); } #endif @@ -6162,6 +6163,8 @@ int smart_initialize(int minor, FAR struct mtd_dev_s *mtd, smart_zalloc(NULL, sizeof(struct smart_struct_s), "Dev struct"); if (dev) { + char devname[18]; + /* Initialize the SMART device structure */ dev->mtd = mtd; @@ -6241,11 +6244,12 @@ int smart_initialize(int minor, FAR struct mtd_dev_s *mtd, #ifdef CONFIG_SMARTFS_MULTI_ROOT_DIRS if (partname != NULL) { - snprintf(dev->rwbuffer, 18, "/dev/smart%d%sd1", minor, partname); + snprintf(devname, sizeof(devname), "/dev/smart%d%sd1", minor, + partname); } else { - snprintf(dev->rwbuffer, 18, "/dev/smart%dd1", minor); + snprintf(devname, sizeof(devname), "/dev/smart%dd1", minor); } /* Inode private data is a reference to a struct containing @@ -6265,21 +6269,22 @@ int smart_initialize(int minor, FAR struct mtd_dev_s *mtd, rootdirdev->dev = dev; rootdirdev->rootdirnum = 0; - ret = register_blockdriver(dev->rwbuffer, &g_bops, 0, rootdirdev); + ret = register_blockdriver(devname, &g_bops, 0, rootdirdev); #else if (partname != NULL) { - snprintf(dev->rwbuffer, 18, "/dev/smart%d%s", minor, partname); + snprintf(devname, sizeof(devname), "/dev/smart%d%s", minor, + partname); } else { - snprintf(dev->rwbuffer, 18, "/dev/smart%d", minor); + snprintf(devname, sizeof(devname), "/dev/smart%d", minor); } /* Inode private data is a reference to the SMART device structure */ - ret = register_blockdriver(dev->rwbuffer, &g_bops, 0, dev); + ret = register_blockdriver(devname, &g_bops, 0, dev); #endif if (ret < 0) diff --git a/drivers/rmt/rmtchar.c b/drivers/rmt/rmtchar.c index 2c22e8d1c0..bc0dad8591 100644 --- a/drivers/rmt/rmtchar.c +++ b/drivers/rmt/rmtchar.c @@ -317,7 +317,7 @@ int rmtchar_register(FAR struct rmt_dev_s *rmt) /* Create the character device name */ - snprintf(devname, DEVNAME_FMTLEN, DEVNAME_FMT, priv->minor); + snprintf(devname, sizeof(devname), DEVNAME_FMT, priv->minor); ret = register_driver(devname, &g_rmt_channel_fops, 0666, priv); if (ret < 0) { diff --git a/drivers/serial/pty.c b/drivers/serial/pty.c index e9272cdb72..3c668bf38b 100644 --- a/drivers/serial/pty.c +++ b/drivers/serial/pty.c @@ -158,7 +158,7 @@ static void pty_destroy(FAR struct pty_devpair_s *devpair) /* Un-register the slave device */ - snprintf(devname, 16, "/dev/pts/%d", devpair->pp_minor); + snprintf(devname, sizeof(devname), "/dev/pts/%u", devpair->pp_minor); } else { @@ -166,12 +166,12 @@ static void pty_destroy(FAR struct pty_devpair_s *devpair) * unlinked). */ - snprintf(devname, 16, "/dev/pty%d", (int)devpair->pp_minor); + snprintf(devname, sizeof(devname), "/dev/pty%u", devpair->pp_minor); unregister_driver(devname); /* Un-register the slave device */ - snprintf(devname, 16, "/dev/ttyp%d", devpair->pp_minor); + snprintf(devname, sizeof(devname), "/dev/ttyp%u", devpair->pp_minor); } unregister_driver(devname); @@ -1026,7 +1026,7 @@ int pty_register2(int minor, bool susv1) * Where N is the minor number */ - snprintf(devname, 16, "/dev/pty%d", minor); + snprintf(devname, sizeof(devname), "/dev/pty%d", minor); ret = register_driver(devname, &g_pty_fops, 0666, &devpair->pp_master); if (ret < 0) @@ -1044,11 +1044,11 @@ int pty_register2(int minor, bool susv1) if (susv1) { - snprintf(devname, 16, "/dev/pts/%d", minor); + snprintf(devname, sizeof(devname), "/dev/pts/%d", minor); } else { - snprintf(devname, 16, "/dev/ttyp%d", minor); + snprintf(devname, sizeof(devname), "/dev/ttyp%d", minor); } ret = register_driver(devname, &g_pty_fops, 0666, &devpair->pp_slave); @@ -1060,7 +1060,7 @@ int pty_register2(int minor, bool susv1) return OK; errout_with_master: - snprintf(devname, 16, "/dev/pty%d", minor); + snprintf(devname, sizeof(devname), "/dev/pty%d", minor); unregister_driver(devname); errout_with_devpair: diff --git a/drivers/spi/spi_driver.c b/drivers/spi/spi_driver.c index 0774dcd956..c5e49852f6 100644 --- a/drivers/spi/spi_driver.c +++ b/drivers/spi/spi_driver.c @@ -369,7 +369,7 @@ int spi_register(FAR struct spi_dev_s *spi, int bus) /* Create the character device name */ - snprintf(devname, DEVNAME_FMTLEN, DEVNAME_FMT, bus); + snprintf(devname, sizeof(devname), DEVNAME_FMT, bus); ret = register_driver(devname, &g_spidrvr_fops, 0666, priv); if (ret < 0) { diff --git a/drivers/usbdev/cdcacm.c b/drivers/usbdev/cdcacm.c index 31a8d868a8..c3057f7a90 100644 --- a/drivers/usbdev/cdcacm.c +++ b/drivers/usbdev/cdcacm.c @@ -2956,7 +2956,7 @@ int cdcacm_classobject(int minor, FAR struct usbdev_devinfo_s *devinfo, /* Register the CDC/ACM TTY device */ - snprintf(devname, CDCACM_DEVNAME_SIZE, CDCACM_DEVNAME_FORMAT, minor); + snprintf(devname, sizeof(devname), CDCACM_DEVNAME_FORMAT, minor); ret = uart_register(devname, &priv->serdev); if (ret < 0) { @@ -3087,7 +3087,7 @@ void cdcacm_uninitialize(FAR struct usbdevclass_driver_s *classdev) /* Un-register the CDC/ACM TTY device */ - snprintf(devname, CDCACM_DEVNAME_SIZE, CDCACM_DEVNAME_FORMAT, priv->minor); + snprintf(devname, sizeof(devname), CDCACM_DEVNAME_FORMAT, priv->minor); ret = unregister_driver(devname); if (ret < 0) { diff --git a/drivers/usbdev/cdcncm.c b/drivers/usbdev/cdcncm.c index fbae55590e..cf7974bd16 100644 --- a/drivers/usbdev/cdcncm.c +++ b/drivers/usbdev/cdcncm.c @@ -2901,7 +2901,7 @@ static int cdcmbim_classobject(int minor, #ifdef CONFIG_NETDEV_IFINDEX index = self->ncmdriver.dev.netdev.d_ifindex; #endif - snprintf(devname, CDC_MBIM_DEVNAMELEN, CDC_MBIM_DEVFORMAT, index); + snprintf(devname, sizeof(devname), CDC_MBIM_DEVFORMAT, index); ret = register_driver(devname, &g_usbdevfops, 0666, self); if (ret < 0) { diff --git a/drivers/video/fb.c b/drivers/video/fb.c index f2a8223126..01e648104c 100644 --- a/drivers/video/fb.c +++ b/drivers/video/fb.c @@ -1645,11 +1645,11 @@ int fb_register_device(int display, int plane, if (nplanes < 2) { - snprintf(devname, 16, "/dev/fb%d", display); + snprintf(devname, sizeof(devname), "/dev/fb%d", display); } else { - snprintf(devname, 16, "/dev/fb%d.%d", display, plane); + snprintf(devname, sizeof(devname), "/dev/fb%d.%d", display, plane); } ret = register_driver(devname, &g_fb_fops, 0666, fb); diff --git a/drivers/virtio/virtio-snd.c b/drivers/virtio/virtio-snd.c index 210c9a4979..1bbac2e3e0 100644 --- a/drivers/virtio/virtio-snd.c +++ b/drivers/virtio/virtio-snd.c @@ -1141,11 +1141,11 @@ virtio_snd_register_audio_driver(FAR struct virtio_snd_s *priv) switch (priv->info[i].direction) { case VIRTIO_SND_D_OUTPUT: - snprintf(devname, 32, "pcm%dp", tx_minor++); + snprintf(devname, sizeof(devname), "pcm%dp", tx_minor++); break; case VIRTIO_SND_D_INPUT: - snprintf(devname, 32, "pcm%dc", rx_minor++); + snprintf(devname, sizeof(devname), "pcm%dc", rx_minor++); break; } diff --git a/fs/driver/fs_blockproxy.c b/fs/driver/fs_blockproxy.c index 0aafca530a..29dcfa9531 100644 --- a/fs/driver/fs_blockproxy.c +++ b/fs/driver/fs_blockproxy.c @@ -103,7 +103,8 @@ static FAR char *unique_chardev(void) /* Construct the full device number */ devno &= 0xffffff; - snprintf(devbuf, 16, "/dev/tmpc%06lx", (unsigned long)devno); + snprintf(devbuf, sizeof(devbuf), "/dev/tmpc%06lx", + (unsigned long)devno); /* Make sure that file name is not in use */ diff --git a/fs/driver/fs_mtdproxy.c b/fs/driver/fs_mtdproxy.c index 4a73568ad1..72e83a7530 100644 --- a/fs/driver/fs_mtdproxy.c +++ b/fs/driver/fs_mtdproxy.c @@ -96,7 +96,8 @@ static FAR char *unique_blkdev(void) /* Construct the full device number */ devno &= 0xffffff; - snprintf(devbuf, 16, "/dev/tmpb%06lx", (unsigned long)devno); + snprintf(devbuf, sizeof(devbuf), "/dev/tmpb%06lx", + (unsigned long)devno); /* Make sure that file name is not in use */ diff --git a/graphics/nxterm/nxterm_unregister.c b/graphics/nxterm/nxterm_unregister.c index 73551e9fbf..7b790f3ec3 100644 --- a/graphics/nxterm/nxterm_unregister.c +++ b/graphics/nxterm/nxterm_unregister.c @@ -75,7 +75,7 @@ void nxterm_unregister(FAR struct nxterm_state_s *priv) /* Unregister the driver */ - snprintf(devname, NX_DEVNAME_SIZE, NX_DEVNAME_FORMAT, priv->minor); + snprintf(devname, sizeof(devname), NX_DEVNAME_FORMAT, priv->minor); unregister_driver(devname); /* Free the private data structure */ diff --git a/libs/libc/stdlib/lib_openpty.c b/libs/libc/stdlib/lib_openpty.c index 47db4128a0..6e8056108d 100644 --- a/libs/libc/stdlib/lib_openpty.c +++ b/libs/libc/stdlib/lib_openpty.c @@ -78,7 +78,7 @@ int posix_openpt(int oflag) char devname[16]; int fd; - snprintf(devname, 16, "/dev/pty%d", minor); + snprintf(devname, sizeof(devname), "/dev/pty%d", minor); fd = open(devname, oflag); if (fd < 0) { diff --git a/wireless/ieee802154/mac802154_device.c b/wireless/ieee802154/mac802154_device.c index 758087940d..536c14a399 100644 --- a/wireless/ieee802154/mac802154_device.c +++ b/wireless/ieee802154/mac802154_device.c @@ -855,7 +855,7 @@ int mac802154dev_register(MACHANDLE mac, int minor) /* Create the character device name */ - snprintf(devname, DEVNAME_FMTLEN, DEVNAME_FMT, minor); + snprintf(devname, sizeof(devname), DEVNAME_FMT, minor); /* Register the mac character driver */
