xiaoxiang781216 commented on code in PR #13018: URL: https://github.com/apache/nuttx/pull/13018#discussion_r1731524052
########## sched/irq/irq_attach_thread.c: ########## @@ -0,0 +1,213 @@ +/**************************************************************************** + * sched/irq/irq_attach_thread.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <errno.h> +#include <stdio.h> + +#include <nuttx/irq.h> +#include <nuttx/arch.h> +#include <nuttx/kthread.h> + +#include "irq/irq.h" +#include "sched/sched.h" + +/**************************************************************************** + * Privte Types + ****************************************************************************/ + +/* This is the type of the list of interrupt handlers, one for each IRQ. + * This type provided all of the information necessary to irq_dispatch to + * transfer control to interrupt handlers after the occurrence of an + * interrupt. + */ + +struct irq_thread_info_s +{ + xcpt_t handler; /* Address of the interrupt handler */ + FAR void *arg; /* The argument provided to the interrupt handler. */ + FAR sem_t *sem; /* irq sem used to notify irq thread */ +}; + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static pid_t g_irq_thread_pid[NR_IRQS]; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/* Default interrupt handler for threaded interrupts. + * Useful for oneshot interrupts. + */ + +static int irq_default_handler(int irq, FAR void *regs, FAR void *arg) +{ + FAR struct irq_thread_info_s *info = arg; + int ret = IRQ_WAKE_THREAD; + xcpt_t vector; + + DEBUGASSERT(info->handler != NULL); + vector = info->handler; + + ret = vector(irq, regs, info->arg); + + if (ret == IRQ_WAKE_THREAD) + { + nxsem_post(info->sem); + ret = OK; + } + + return ret; +} + +static int isr_thread_main(int argc, FAR char *argv[]) +{ + int irq = atoi(argv[1]); + xcpt_t isr = (xcpt_t)((uintptr_t)strtoul(argv[2], NULL, 16)); + xcpt_t isrthread = (xcpt_t)((uintptr_t)strtoul(argv[3], NULL, 16)); + FAR void *arg = (FAR void *)((uintptr_t)strtoul(argv[4], NULL, 16)); + struct irq_thread_info_s info; + sem_t sem; + + info.sem = &sem; + info.arg = arg; + info.handler = isr; + + nxsem_init(&sem, 0, 0); + + irq_attach(irq, irq_default_handler, &info); + +#if !defined(CONFIG_ARCH_NOINTC) + up_enable_irq(irq); +#endif + + for (; ; ) + { + int ret; + ret = nxsem_wait_uninterruptible(&sem); + if (ret < 0) Review Comment: ```suggestion if (nxsem_wait_uninterruptible(&sem) < 0) ``` and remove ret ########## sched/irq/irq_attach_thread.c: ########## @@ -0,0 +1,213 @@ +/**************************************************************************** + * sched/irq/irq_attach_thread.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <errno.h> +#include <stdio.h> + +#include <nuttx/irq.h> +#include <nuttx/arch.h> +#include <nuttx/kthread.h> + +#include "irq/irq.h" +#include "sched/sched.h" + +/**************************************************************************** + * Privte Types + ****************************************************************************/ + +/* This is the type of the list of interrupt handlers, one for each IRQ. + * This type provided all of the information necessary to irq_dispatch to + * transfer control to interrupt handlers after the occurrence of an + * interrupt. + */ + +struct irq_thread_info_s +{ + xcpt_t handler; /* Address of the interrupt handler */ + FAR void *arg; /* The argument provided to the interrupt handler. */ + FAR sem_t *sem; /* irq sem used to notify irq thread */ +}; + +/**************************************************************************** + * Private Data + ****************************************************************************/ + +static pid_t g_irq_thread_pid[NR_IRQS]; + +/**************************************************************************** + * Private Functions + ****************************************************************************/ + +/* Default interrupt handler for threaded interrupts. + * Useful for oneshot interrupts. + */ + +static int irq_default_handler(int irq, FAR void *regs, FAR void *arg) +{ + FAR struct irq_thread_info_s *info = arg; + int ret = IRQ_WAKE_THREAD; + xcpt_t vector; + + DEBUGASSERT(info->handler != NULL); + vector = info->handler; + + ret = vector(irq, regs, info->arg); Review Comment: ```suggestion ret = info->handler(irq, regs, info->arg); ``` remove vector -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
