anchao commented on code in PR #13211:
URL: https://github.com/apache/nuttx/pull/13211#discussion_r1735428375
##########
drivers/syslog/vsyslog.c:
##########
@@ -215,7 +215,7 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR
va_list *ap)
#endif
#if defined(CONFIG_SMP)
- , up_cpu_index()
Review Comment:
should be up_cpu_index() not this_cpu()
##########
arch/arm/src/armv8-r/arm_gicv3.c:
##########
@@ -799,7 +799,7 @@ static void arm_gic_init(void)
cpu = this_cpu();
gic_rdists[cpu] = CONFIG_GICR_BASE +
- up_cpu_index() * CONFIG_GICR_OFFSET;
+ this_cpu() * CONFIG_GICR_OFFSET;
Review Comment:
ditto
##########
arch/arm/src/armv8-r/arm_gicv3.c:
##########
@@ -247,7 +247,7 @@ void arm_gic_irq_enable(unsigned int intid)
if (GIC_IS_SPI(intid))
{
- arm_gic_write_irouter(up_cpu_index(), intid);
+ arm_gic_write_irouter(this_cpu(), intid);
Review Comment:
should be up_cpu_index() not this_cpu()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
