xiaoxiang781216 commented on code in PR #13251:
URL: https://github.com/apache/nuttx/pull/13251#discussion_r1738688802
##########
drivers/usbdev/rndis.c:
##########
@@ -2007,8 +2014,9 @@ static int16_t usbclass_mkcfgdesc(FAR uint8_t *buf,
totallen += sizeof(struct usb_ifdesc_s);
+ epno = devinfo == NULL ? 0 : devinfo->epno[RNDIS_EP_INTIN_IDX];
Review Comment:
```suggestion
epno = devinfo ? devinfo->epno[RNDIS_EP_INTIN_IDX] : 0;
```
##########
drivers/usbdev/rndis.c:
##########
@@ -2032,8 +2040,9 @@ static int16_t usbclass_mkcfgdesc(FAR uint8_t *buf,
totallen += sizeof(struct usb_ifdesc_s);
+ epno = devinfo == NULL ? 0 : devinfo->epno[RNDIS_EP_BULKIN_IDX];
Review Comment:
```suggestion
epno = devinfo ? devinfo->epno[RNDIS_EP_BULKIN_IDX] : 0;
```
##########
drivers/usbdev/rndis.c:
##########
@@ -2043,8 +2052,9 @@ static int16_t usbclass_mkcfgdesc(FAR uint8_t *buf,
totallen += ret;
+ epno = devinfo == NULL ? 0 : devinfo->epno[RNDIS_EP_BULKOUT_IDX];
Review Comment:
```suggestion
epno = devinfo ? devinfo->epno[RNDIS_EP_BULKOUT_IDX] : 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
