acassis commented on pull request #1268: URL: https://github.com/apache/incubator-nuttx/pull/1268#issuecomment-645995169
Congratulations Jacob! Now it is passing in the CI tests. I was going to Merge it when I saw the raiden00pl question about why you created a new file to RCC configuration. Do you think it is possible to use the existing file? @raiden00pl for consistency do you think he could rename stm32f40xxx_rcc.c to stm32f4xxxx_rcc.c ? Also if this RCC is different enough to include many #ifdefs inside stm32f40xxx_rcc.c, then I think it is better to keep it in a different file. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
